Re: [PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-12-07 Thread Thomas Huth
On 07/12/2020 11.26, BALATON Zoltan via wrote: > On Mon, 7 Dec 2020, Alexey Kardashevskiy wrote: >> On 05/12/2020 05:32, Greg Kurz wrote: >>> On Tue, 13 Oct 2020 13:19:11 +1100 >>> Alexey Kardashevskiy wrote: >>> +static void readstr(hwaddr pa, char *buf, int size) +{ +    cpu_physi

Re: [PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-12-07 Thread BALATON Zoltan via
On Mon, 7 Dec 2020, Greg Kurz wrote: On Mon, 7 Dec 2020 18:33:34 +1100 Alexey Kardashevskiy wrote: [...] +} + +return offset; +} + +static uint32_t of_client_finddevice(const void *fdt, uint32_t nodeaddr) +{ +char *node, *unit, *part; If you do this: g_autofree *node = NUL

Re: [PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-12-07 Thread BALATON Zoltan via
On Mon, 7 Dec 2020, Alexey Kardashevskiy wrote: On 05/12/2020 05:32, Greg Kurz wrote: On Tue, 13 Oct 2020 13:19:11 +1100 Alexey Kardashevskiy wrote: +static void readstr(hwaddr pa, char *buf, int size) +{ +cpu_physical_memory_read(pa, buf, size); +if (buf[size - 1] != '\0') { +

Re: [PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-12-07 Thread Greg Kurz
On Mon, 7 Dec 2020 18:33:34 +1100 Alexey Kardashevskiy wrote: [...] > >> +} > >> + > >> +return offset; > >> +} > >> + > >> +static uint32_t of_client_finddevice(const void *fdt, uint32_t nodeaddr) > >> +{ > >> +char *node, *unit, *part; > > > > If you do this: > > > > g_autof

Re: [PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-12-06 Thread Alexey Kardashevskiy
On 05/12/2020 05:32, Greg Kurz wrote: On Tue, 13 Oct 2020 13:19:11 +1100 Alexey Kardashevskiy wrote: The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and t

Re: [PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-12-05 Thread Alexey Kardashevskiy
On 05/12/2020 05:43, Greg Kurz wrote: On Fri, 4 Dec 2020 19:32:05 +0100 Greg Kurz wrote: That's all for now. Just one last item. I'm observing failures with nvram in the guest: [root@vir76 ~]# nvram --print-config [ 88.179444] nvram[936]: unhandled signal 11 at 7fffc83a nip 0

Re: [PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-12-04 Thread Greg Kurz
On Fri, 4 Dec 2020 19:32:05 +0100 Greg Kurz wrote: > > That's all for now. > Just one last item. I'm observing failures with nvram in the guest: [root@vir76 ~]# nvram --print-config [ 88.179444] nvram[936]: unhandled signal 11 at 7fffc83a nip 00012d802110 lr 00012d802118 cod

Re: [PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-12-04 Thread Greg Kurz
On Tue, 13 Oct 2020 13:19:11 +1100 Alexey Kardashevskiy wrote: > The PAPR platform which describes an OS environment that's presented by > a combination of a hypervisor and firmware. The features it specifies > require collaboration between the firmware and the hypervisor. > > Since the beginnin

Re: [PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-10-31 Thread Greg Kurz
On Sat, 31 Oct 2020 16:53:24 +1100 Alexey Kardashevskiy wrote: > Has anyone at least tried this, or everybody is busy KVMforuming? :) > Yeah virtualKVMforuming :) I had tried when you posted this v10 but I didn't get far at the time, because the kernel I was passing didn't want to boot and th

Re: [PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-10-30 Thread Alexey Kardashevskiy
Has anyone at least tried this, or everybody is busy KVMforuming? :) On 13/10/2020 13:19, Alexey Kardashevskiy wrote: The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the

[PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-10-12 Thread Alexey Kardashevskiy
The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of the firmware (RTAS) has been implemented as a 2