On Fri, Oct 06, 2023 at 02:36:52AM +, Damien Zammit wrote:
> >From: Michael Tokarev
> >26.02.2023 04:58, Damien Zammit wrote:
> >> Currently, the one-shot (mode 1) PIT expires far too quickly,
> >> due to the output being set under the wrong logic.
> >> This change fixes the one-shot PIT mode
>From: Michael Tokarev
>26.02.2023 04:58, Damien Zammit wrote:
>> Currently, the one-shot (mode 1) PIT expires far too quickly,
>> due to the output being set under the wrong logic.
>> This change fixes the one-shot PIT mode to behave similarly to mode 0.
>>
>> TESTED: using the one-shot PIT mode
26.02.2023 04:58, Damien Zammit wrote:
Currently, the one-shot (mode 1) PIT expires far too quickly,
due to the output being set under the wrong logic.
This change fixes the one-shot PIT mode to behave similarly to mode 0.
TESTED: using the one-shot PIT mode to calibrate a local apic timer.
Ha
On Sun, Feb 26, 2023 at 01:11:19PM +0100, BALATON Zoltan wrote:
> On Sun, 26 Feb 2023, Max Filippov wrote:
> > On Sun, Feb 26, 2023 at 1:18 AM Damien Zammit wrote:
> > >
> > > Hi Michael,
> > >
> > > Thanks for reviewing this on a weekend!
> > >
> > > On 26/2/23 19:51, Michael S. Tsirkin wrote:
On Sun, 26 Feb 2023, Max Filippov wrote:
On Sun, Feb 26, 2023 at 1:18 AM Damien Zammit wrote:
Hi Michael,
Thanks for reviewing this on a weekend!
On 26/2/23 19:51, Michael S. Tsirkin wrote:
On Sun, Feb 26, 2023 at 01:58:10AM +, Damien Zammit wrote:
case 0:
-out = (d >= s-
On Sun, Feb 26, 2023 at 1:18 AM Damien Zammit wrote:
>
> Hi Michael,
>
> Thanks for reviewing this on a weekend!
>
> On 26/2/23 19:51, Michael S. Tsirkin wrote:
> > On Sun, Feb 26, 2023 at 01:58:10AM +, Damien Zammit wrote:
> >> case 0:
> >> -out = (d >= s->count);
> >> -
Hi Michael,
Thanks for reviewing this on a weekend!
On 26/2/23 19:51, Michael S. Tsirkin wrote:
> On Sun, Feb 26, 2023 at 01:58:10AM +, Damien Zammit wrote:
>> case 0:
>> -out = (d >= s->count);
>> -break;
>
>
> I think you need something like
> /* FALLTHRU */
> he
On Sun, Feb 26, 2023 at 01:58:10AM +, Damien Zammit wrote:
> Currently, the one-shot (mode 1) PIT expires far too quickly,
> due to the output being set under the wrong logic.
> This change fixes the one-shot PIT mode to behave similarly to mode 0.
>
> TESTED: using the one-shot PIT mode to ca
Currently, the one-shot (mode 1) PIT expires far too quickly,
due to the output being set under the wrong logic.
This change fixes the one-shot PIT mode to behave similarly to mode 0.
TESTED: using the one-shot PIT mode to calibrate a local apic timer.
Signed-off-by: Damien Zammit
---
hw/timer
