Re: [PATCH qemu] s390x: sck: load into a temporary not into in1

2022-01-25 Thread David Hildenbrand
On 25.01.22 17:42, Philippe Mathieu-Daudé wrote: > On 25/1/22 15:54, Nico Boehr wrote: >> On Tue, 2022-01-25 at 14:13 +0100, David Hildenbrand wrote: >>> I think you can actually just reuse in2_m2_64a, similar as we handle >>> SCKC >> >> I tried my SCK tests with your patch, it works just as well a

Re: [PATCH qemu] s390x: sck: load into a temporary not into in1

2022-01-25 Thread Philippe Mathieu-Daudé via
On 25/1/22 15:54, Nico Boehr wrote: On Tue, 2022-01-25 at 14:13 +0100, David Hildenbrand wrote: I think you can actually just reuse in2_m2_64a, similar as we handle SCKC I tried my SCK tests with your patch, it works just as well and seems much cleaner, thanks. Do you want to send this or sho

Re: [PATCH qemu] s390x: sck: load into a temporary not into in1

2022-01-25 Thread Nico Boehr
On Tue, 2022-01-25 at 14:13 +0100, David Hildenbrand wrote: > I think you can actually just reuse in2_m2_64a, similar as we handle > SCKC I tried my SCK tests with your patch, it works just as well and seems much cleaner, thanks. Do you want to send this or should I make a v2 and add you as Sugge

Re: [PATCH qemu] s390x: sck: load into a temporary not into in1

2022-01-25 Thread David Hildenbrand
On 25.01.22 13:29, Nico Boehr wrote: > We previously loaded into in1, but in1 is not filled during > disassembly and hence always zero. This leads to an assertion failure: > > qemu-system-s390x: /home/nrb/qemu/include/tcg/tcg.h:654: temp_idx: > Assertion `n >= 0 && n < tcg_ctx->nb_temps' faile

[PATCH qemu] s390x: sck: load into a temporary not into in1

2022-01-25 Thread Nico Boehr
We previously loaded into in1, but in1 is not filled during disassembly and hence always zero. This leads to an assertion failure: qemu-system-s390x: /home/nrb/qemu/include/tcg/tcg.h:654: temp_idx: Assertion `n >= 0 && n < tcg_ctx->nb_temps' failed.` Instead, load into a temporary and pass th