Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Zhao Liu
> > If we're re-writing C devices in Rust, we need to be able to promptly > > drop the C impl once the Rust impl is feature complete. Keeping 2 impls > > is a general maint burden, as well as an ongoing vmstate compatibility > > danger if a change in one impl is not matched by an identical change >

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Paolo Bonzini
Il mar 6 mag 2025, 13:52 Daniel P. Berrangé ha scritto: > > On the other hand, this series shows that it's hard to have a baseline > > version earlier than 1.83. The bindings got pretty far while > > supporting older versions, and the few hacks needed were nice testbeds > > for the build system

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Daniel P . Berrangé
On Tue, May 06, 2025 at 12:54:38PM +0200, Paolo Bonzini wrote: > On Tue, May 6, 2025 at 11:49 AM Daniel P. Berrangé > wrote: > > > > [...] If Rust is missing or old, "enable > > > > all devices written in Rust" will fail compilation (e.g. Kconfig would > > > > fail for ARM/x86 targets due to unsa

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Paolo Bonzini
On Tue, May 6, 2025 at 11:49 AM Daniel P. Berrangé wrote: > > > [...] If Rust is missing or old, "enable > > > all devices written in Rust" will fail compilation (e.g. Kconfig would > > > fail for ARM/x86 targets due to unsatisfiable CONFIG_PL011); > > > "enable Rust" will simply pick the C versio

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Daniel P . Berrangé
On Tue, May 06, 2025 at 05:26:12PM +0800, Zhao Liu wrote: > > > "enable Rust" supports v1.77 and "enable all devices written in Rust" > > > supports v1.83, correct? > > > > Both support v1.83 only. However, if Rust is missing or old, "enable > > all devices written in Rust" will fail compilation

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Daniel P . Berrangé
On Tue, May 06, 2025 at 05:26:12PM +0800, Zhao Liu wrote: > > > "enable Rust" supports v1.77 and "enable all devices written in Rust" > > > supports v1.83, correct? > > > > Both support v1.83 only. However, if Rust is missing or old, "enable > > all devices written in Rust" will fail compilation

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Zhao Liu
> > "enable Rust" supports v1.77 and "enable all devices written in Rust" > > supports v1.83, correct? > > Both support v1.83 only. However, if Rust is missing or old, "enable > all devices written in Rust" will fail compilation (e.g. Kconfig would > fail for ARM/x86 targets due to unsatisfiable

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Paolo Bonzini
On Tue, May 6, 2025 at 10:35 AM Zhao Liu wrote: > > > This series does not cover enabling the newer compiler in CI because, > > while both Debian and Ubuntu have a new-enough Rust compiler to support > > 1.77, they pose problems for this further bump. For Debian, the bookworm > > release probably

Re: [PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-06 Thread Zhao Liu
> This series does not cover enabling the newer compiler in CI because, > while both Debian and Ubuntu have a new-enough Rust compiler to support > 1.77, they pose problems for this further bump. For Debian, the bookworm > release probably will not have new compilers and is supported by QEMU > for

[PATCH preview 0/5] rust: allow minimum version of 1.83

2025-05-05 Thread Paolo Bonzini
This is the preview of moving the minimum supported Rust version forward to 1.83.0, which is the target for QEMU due to its support for the const_refs_to_static feature. Being able to autogenerate all the reflection-like structs in qdev and VMState improves the type safety, but also requires annot