Re: [PATCH for 6.1 1/2] ui/gtk: add a keyboard fifo to the VTE consoles

2021-07-21 Thread Volker Rümelin
+static void gd_vc_send_chars(VirtualConsole *vc) +{ +uint32_t len, avail; +const uint8_t *buf; + +len = qemu_chr_be_can_write(vc->vte.chr); +avail = fifo8_num_used(&vc->vte.out_fifo); +if (len > avail) { +len = avail; +} +while (len > 0) { +uint32_t siz

Re: [PATCH for 6.1 1/2] ui/gtk: add a keyboard fifo to the VTE consoles

2021-07-21 Thread Gerd Hoffmann
Hi, > +static void gd_vc_send_chars(VirtualConsole *vc) > +{ > +uint32_t len, avail; > +const uint8_t *buf; > + > +len = qemu_chr_be_can_write(vc->vte.chr); > +avail = fifo8_num_used(&vc->vte.out_fifo); > +if (len > avail) { > +len = avail; > +} > +while (len

Re: [PATCH for 6.1 1/2] ui/gtk: add a keyboard fifo to the VTE consoles

2021-07-19 Thread Peter Maydell
On Mon, 19 Jul 2021 at 19:41, Daniel P. Berrangé wrote: > > On Mon, Jul 19, 2021 at 07:37:23PM +0100, Peter Maydell wrote: > > On Mon, 19 Jul 2021 at 19:22, Volker Rümelin wrote: > > > > > > Am 18.07.21 um 15:00 schrieb Peter Maydell: > > > > > > > On Sun, 18 Jul 2021 at 08:50, Volker Rümelin >

Re: [PATCH for 6.1 1/2] ui/gtk: add a keyboard fifo to the VTE consoles

2021-07-19 Thread Daniel P . Berrangé
On Mon, Jul 19, 2021 at 07:37:23PM +0100, Peter Maydell wrote: > On Mon, 19 Jul 2021 at 19:22, Volker Rümelin wrote: > > > > Am 18.07.21 um 15:00 schrieb Peter Maydell: > > > > > On Sun, 18 Jul 2021 at 08:50, Volker Rümelin wrote: > > >> Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple

Re: [PATCH for 6.1 1/2] ui/gtk: add a keyboard fifo to the VTE consoles

2021-07-19 Thread Peter Maydell
On Mon, 19 Jul 2021 at 19:22, Volker Rümelin wrote: > > Am 18.07.21 um 15:00 schrieb Peter Maydell: > > > On Sun, 18 Jul 2021 at 08:50, Volker Rümelin wrote: > >> Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple > >> characeters") it's very easy to lock up QEMU with the gtk ui. > >> If

Re: [PATCH for 6.1 1/2] ui/gtk: add a keyboard fifo to the VTE consoles

2021-07-19 Thread Volker Rümelin
Am 18.07.21 um 15:00 schrieb Peter Maydell: On Sun, 18 Jul 2021 at 08:50, Volker Rümelin wrote: Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple characeters") it's very easy to lock up QEMU with the gtk ui. If you configure a guest with a serial device and the guest doesn't listen o

Re: [PATCH for 6.1 1/2] ui/gtk: add a keyboard fifo to the VTE consoles

2021-07-19 Thread Daniel P . Berrangé
On Sun, Jul 18, 2021 at 02:00:03PM +0100, Peter Maydell wrote: > On Sun, 18 Jul 2021 at 08:50, Volker Rümelin wrote: > > > > Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple > > characeters") it's very easy to lock up QEMU with the gtk ui. > > If you configure a guest with a serial devi

Re: [PATCH for 6.1 1/2] ui/gtk: add a keyboard fifo to the VTE consoles

2021-07-18 Thread Peter Maydell
On Sun, 18 Jul 2021 at 08:50, Volker Rümelin wrote: > > Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple > characeters") it's very easy to lock up QEMU with the gtk ui. > If you configure a guest with a serial device and the guest > doesn't listen on this device, QEMU will lock up after

[PATCH for 6.1 1/2] ui/gtk: add a keyboard fifo to the VTE consoles

2021-07-18 Thread Volker Rümelin
Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple characeters") it's very easy to lock up QEMU with the gtk ui. If you configure a guest with a serial device and the guest doesn't listen on this device, QEMU will lock up after entering two characters in the serial console. To fix this pr