Re: [PATCH for 6.1] multifd: Unconditionally unregister yank function

2021-09-08 Thread Juan Quintela
Lukas Straub wrote: > Unconditionally unregister yank function in multifd_load_cleanup(). > If it is not unregistered here, it will leak and cause a crash > in yank_unregister_instance(). Now if the ioc is still in use > afterwards, it will only lead to qemu not being able to recover > from a hang

Re: [PATCH for 6.1] multifd: Unconditionally unregister yank function

2021-09-01 Thread Lukas Straub
On Wed, 4 Aug 2021 21:26:32 +0200 Lukas Straub wrote: > Unconditionally unregister yank function in multifd_load_cleanup(). > If it is not unregistered here, it will leak and cause a crash > in yank_unregister_instance(). Now if the ioc is still in use > afterwards, it will only lead to qemu not

Re: [PATCH for 6.1] multifd: Unconditionally unregister yank function

2021-08-04 Thread Lukas Straub
On Wed, 4 Aug 2021 15:39:55 -0400 Peter Xu wrote: > On Wed, Aug 04, 2021 at 09:26:32PM +0200, Lukas Straub wrote: > > Unconditionally unregister yank function in multifd_load_cleanup(). > > If it is not unregistered here, it will leak and cause a crash > > in yank_unregister_instance(). > > Cu

Re: [PATCH for 6.1] multifd: Unconditionally unregister yank function

2021-08-04 Thread Peter Xu
On Wed, Aug 04, 2021 at 09:26:32PM +0200, Lukas Straub wrote: > Unconditionally unregister yank function in multifd_load_cleanup(). > If it is not unregistered here, it will leak and cause a crash > in yank_unregister_instance(). Curious whether there was a crash somewhere that you hit? > Now if

[PATCH for 6.1] multifd: Unconditionally unregister yank function

2021-08-04 Thread Lukas Straub
Unconditionally unregister yank function in multifd_load_cleanup(). If it is not unregistered here, it will leak and cause a crash in yank_unregister_instance(). Now if the ioc is still in use afterwards, it will only lead to qemu not being able to recover from a hang related to that ioc. After ch