Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

2023-12-06 Thread Fiona Ebner
Am 04.12.23 um 08:30 schrieb Marc-André Lureau: > Hi > > On Tue, Nov 28, 2023 at 2:52 PM Marc-André Lureau > wrote: >> >> >> It's hard to make the best decision. >> >> We could return the uncompressed data so far, that would fix the >> regression. But potentially, we have incomplete data returned

Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

2023-12-03 Thread Marc-André Lureau
Hi On Tue, Nov 28, 2023 at 2:52 PM Marc-André Lureau wrote: > > Hi > > On Mon, Nov 27, 2023 at 2:52 PM Fiona Ebner wrote: > > > > Am 27.11.23 um 10:15 schrieb Marc-André Lureau: > > > > > > It seems like a bug in tigervnc then. For some reason, the compressed > > > data doesn't trigger Z_STREAM_

Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

2023-11-28 Thread Marc-André Lureau
Hi On Mon, Nov 27, 2023 at 2:52 PM Fiona Ebner wrote: > > Am 27.11.23 um 10:15 schrieb Marc-André Lureau: > > > > It seems like a bug in tigervnc then. For some reason, the compressed > > data doesn't trigger Z_STREAM_END on the decompression side. Have you > > investigated or reported an issue t

Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

2023-11-27 Thread Fiona Ebner
Am 27.11.23 um 10:15 schrieb Marc-André Lureau: > > It seems like a bug in tigervnc then. For some reason, the compressed > data doesn't trigger Z_STREAM_END on the decompression side. Have you > investigated or reported an issue to them? > This was with noVNC. A colleague tested with TigerVNC.

Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

2023-11-27 Thread Marc-André Lureau
Hi On Thu, Nov 23, 2023 at 12:46 PM Fiona Ebner wrote: > > Am 23.11.23 um 07:52 schrieb Marc-André Lureau: > > Hi > > > > On Wed, Nov 22, 2023 at 5:25 PM Fiona Ebner wrote: > >> > >> Am 22.11.23 um 14:06 schrieb Marc-André Lureau: > >>> Hi > >>> > >>> On Wed, Nov 22, 2023 at 5:00 PM Fiona Ebner

Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

2023-11-23 Thread Fiona Ebner
Am 23.11.23 um 07:52 schrieb Marc-André Lureau: > Hi > > On Wed, Nov 22, 2023 at 5:25 PM Fiona Ebner wrote: >> >> Am 22.11.23 um 14:06 schrieb Marc-André Lureau: >>> Hi >>> >>> On Wed, Nov 22, 2023 at 5:00 PM Fiona Ebner wrote: Commit d921fea338 ("ui/vnc-clipboard: fix infinite loop in

Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

2023-11-22 Thread Marc-André Lureau
Hi On Wed, Nov 22, 2023 at 5:25 PM Fiona Ebner wrote: > > Am 22.11.23 um 14:06 schrieb Marc-André Lureau: > > Hi > > > > On Wed, Nov 22, 2023 at 5:00 PM Fiona Ebner wrote: > >> > >> Commit d921fea338 ("ui/vnc-clipboard: fix infinite loop in > >> inflate_buffer (CVE-2023-3255)") removed this hunk

Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

2023-11-22 Thread Fiona Ebner
Am 22.11.23 um 14:06 schrieb Marc-André Lureau: > Hi > > On Wed, Nov 22, 2023 at 5:00 PM Fiona Ebner wrote: >> >> Commit d921fea338 ("ui/vnc-clipboard: fix infinite loop in >> inflate_buffer (CVE-2023-3255)") removed this hunk, but it is still >> required, because it can happen that stream.avail_

Re: [PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

2023-11-22 Thread Marc-André Lureau
Hi On Wed, Nov 22, 2023 at 5:00 PM Fiona Ebner wrote: > > Commit d921fea338 ("ui/vnc-clipboard: fix infinite loop in > inflate_buffer (CVE-2023-3255)") removed this hunk, but it is still > required, because it can happen that stream.avail_in becomes zero > before coming across a return value of Z

[PATCH for-8.2] ui/vnc-clipboard: fix inflate_buffer

2023-11-22 Thread Fiona Ebner
Commit d921fea338 ("ui/vnc-clipboard: fix infinite loop in inflate_buffer (CVE-2023-3255)") removed this hunk, but it is still required, because it can happen that stream.avail_in becomes zero before coming across a return value of Z_STREAM_END in the loop. This fixes the host->guest direction of