Re: [PATCH for-8.1 1/1] hw/riscv/virt.c: change 'aclint' TCG check

2023-08-11 Thread Alistair Francis
On Fri, Aug 11, 2023 at 12:03 PM Daniel Henrique Barboza wrote: > > The 'aclint' property is being conditioned with tcg acceleration in > virt_machine_class_init(). But acceleration code starts later than the > class init of the board, meaning that tcg_enabled() will be always be > false during cl

Re: [PATCH for-8.1 1/1] hw/riscv/virt.c: change 'aclint' TCG check

2023-08-11 Thread Philippe Mathieu-Daudé
On 11/8/23 18:02, Daniel Henrique Barboza wrote: The 'aclint' property is being conditioned with tcg acceleration in virt_machine_class_init(). But acceleration code starts later than the class init of the board, meaning that tcg_enabled() will be always be false during class_init(), and the opti

[PATCH for-8.1 1/1] hw/riscv/virt.c: change 'aclint' TCG check

2023-08-11 Thread Daniel Henrique Barboza
The 'aclint' property is being conditioned with tcg acceleration in virt_machine_class_init(). But acceleration code starts later than the class init of the board, meaning that tcg_enabled() will be always be false during class_init(), and the option is never being declared even when declaring TCG