Re: [PATCH for-8.0 0/2] hw/input/ps2: Convert to 3-phase reset

2022-12-16 Thread Peter Maydell
On Wed, 9 Nov 2022 at 17:00, Peter Maydell wrote: > > This patchset converts the ps2 keyboard and mouse devices to 3-phase > reset. The rationale here is that it would be nice to get rid of the > device_class_set_parent_reset() function, which is used by > legacy-reset subclasses which want to cha

Re: [PATCH for-8.0 0/2] hw/input/ps2: Convert to 3-phase reset

2022-11-10 Thread Mark Cave-Ayland
On 10/11/2022 11:22, Peter Maydell wrote: On Thu, 10 Nov 2022 at 10:36, Mark Cave-Ayland wrote: I haven't used the new ResettableClass myself previously, however it seems to match the excellent documentation at https://qemu.readthedocs.io/en/latest/devel/reset.html so feel free to add my Ack

Re: [PATCH for-8.0 0/2] hw/input/ps2: Convert to 3-phase reset

2022-11-10 Thread Peter Maydell
On Thu, 10 Nov 2022 at 10:36, Mark Cave-Ayland wrote: > I haven't used the new ResettableClass myself previously, however it seems to > match > the excellent documentation at > https://qemu.readthedocs.io/en/latest/devel/reset.html > so feel free to add my Acked-by tag. > > One part that did sta

Re: [PATCH for-8.0 0/2] hw/input/ps2: Convert to 3-phase reset

2022-11-10 Thread Mark Cave-Ayland
On 09/11/2022 17:00, Peter Maydell wrote: This patchset converts the ps2 keyboard and mouse devices to 3-phase reset. The rationale here is that it would be nice to get rid of the device_class_set_parent_reset() function, which is used by legacy-reset subclasses which want to chain to their pare

[PATCH for-8.0 0/2] hw/input/ps2: Convert to 3-phase reset

2022-11-09 Thread Peter Maydell
This patchset converts the ps2 keyboard and mouse devices to 3-phase reset. The rationale here is that it would be nice to get rid of the device_class_set_parent_reset() function, which is used by legacy-reset subclasses which want to chain to their parent's reset function. There aren't very many o