Re: [PATCH for-7.1 v6 25/51] target/nios2: Clean up handling of tlbmisc in do_exception

2022-03-17 Thread Richard Henderson
On 3/17/22 08:41, Peter Maydell wrote: On page 3-21 of https://www.intel.com/content/dam/www/programmable/us/en/pdfs/literature/hb/nios2/n2cpu_nii5v1_01.pdf the description of the WE flag says "Hardware sets the WE flag to one on a TLB permission violation exception, and on a TLB miss exception w

Re: [PATCH for-7.1 v6 25/51] target/nios2: Clean up handling of tlbmisc in do_exception

2022-03-17 Thread Peter Maydell
On Thu, 17 Mar 2022 at 05:23, Richard Henderson wrote: > > The 4 lower bits, D, PERM, BAD, DBL, are unconditionally set on any > exception with EH=0, or so says Table 42 (Processor Status After > Taking Exception). > > We currently do not set PERM or BAD at all, and only set/clear > DBL for tlb mi

[PATCH for-7.1 v6 25/51] target/nios2: Clean up handling of tlbmisc in do_exception

2022-03-16 Thread Richard Henderson
The 4 lower bits, D, PERM, BAD, DBL, are unconditionally set on any exception with EH=0, or so says Table 42 (Processor Status After Taking Exception). We currently do not set PERM or BAD at all, and only set/clear DBL for tlb miss, and do not clear DBL for any other exception. It is a bit confus