Re: [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint

2021-07-21 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 7/20/21 11:53 PM, Philippe Mathieu-Daudé wrote: >> On 7/20/21 11:08 PM, Richard Henderson wrote: >>> On 7/20/21 10:56 AM, Peter Maydell wrote: On Tue, 20 Jul 2021 at 20:54, Richard Henderson wrote: > > This will allow a breakpoint hack to m

Re: [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint

2021-07-20 Thread Richard Henderson
On 7/20/21 11:53 AM, Philippe Mathieu-Daudé wrote: Practically, this is working around what I'd call a gdb bug wrt avr. Which may even have been fixed -- I haven't looked. This is not a bug but a feature to deal with the Harvard architecture. QEMU AVR model is based on GCC sources so uses the s

Re: [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 11:53 PM, Philippe Mathieu-Daudé wrote: > On 7/20/21 11:08 PM, Richard Henderson wrote: >> On 7/20/21 10:56 AM, Peter Maydell wrote: >>> On Tue, 20 Jul 2021 at 20:54, Richard Henderson >>> wrote: This will allow a breakpoint hack to move out of AVR's translator. Sign

Re: [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 11:08 PM, Richard Henderson wrote: > On 7/20/21 10:56 AM, Peter Maydell wrote: >> On Tue, 20 Jul 2021 at 20:54, Richard Henderson >> wrote: >>> >>> This will allow a breakpoint hack to move out of AVR's translator. >>> >>> Signed-off-by: Richard Henderson >> >>> diff --git a/cpu.c b/cp

Re: [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint

2021-07-20 Thread Richard Henderson
On 7/20/21 10:56 AM, Peter Maydell wrote: On Tue, 20 Jul 2021 at 20:54, Richard Henderson wrote: This will allow a breakpoint hack to move out of AVR's translator. Signed-off-by: Richard Henderson diff --git a/cpu.c b/cpu.c index 83059537d7..91d9e38acb 100644 --- a/cpu.c +++ b/cpu.c @@ -2

Re: [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint

2021-07-20 Thread Peter Maydell
On Tue, 20 Jul 2021 at 20:54, Richard Henderson wrote: > > This will allow a breakpoint hack to move out of AVR's translator. > > Signed-off-by: Richard Henderson > diff --git a/cpu.c b/cpu.c > index 83059537d7..91d9e38acb 100644 > --- a/cpu.c > +++ b/cpu.c > @@ -267,8 +267,13 @@ static void bre

[PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint

2021-07-20 Thread Richard Henderson
This will allow a breakpoint hack to move out of AVR's translator. Signed-off-by: Richard Henderson --- include/hw/core/cpu.h | 4 cpu.c | 10 ++ 2 files changed, 14 insertions(+) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 4e0ea68efc..bc864564