Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Cleber Rosa
wangyanan (Y) writes: > Hi Cleber, > > On 2021/7/23 6:25, Cleber Rosa wrote: >> Yanan Wang writes: >> >>> In the SMP configuration, we should either specify a topology >>> parameter with a reasonable value (equal to or greater than 1) >>> or just leave it omitted and QEMU will calculate its valu

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Cornelia Huck
On Fri, Jul 23 2021, "wangyanan (Y)" wrote: > On 2021/7/23 16:02, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >>> On Thu, Jul 22, 2021 at 11:43:26PM +0800, Yanan Wang wrote: +/* + * The topology parameters must be specified equal to or great than one +

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread wangyanan (Y)
On 2021/7/23 16:02, Markus Armbruster wrote: Daniel P. Berrangé writes: On Thu, Jul 22, 2021 at 11:43:26PM +0800, Yanan Wang wrote: In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU wi

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Jul 22, 2021 at 11:43:26PM +0800, Yanan Wang wrote: >> In the SMP configuration, we should either specify a topology >> parameter with a reasonable value (equal to or greater than 1) >> or just leave it omitted and QEMU will calculate its value. >> Configurati

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-22 Thread wangyanan (Y)
Hi Cleber, On 2021/7/23 6:25, Cleber Rosa wrote: Yanan Wang writes: In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU will calculate its value. Configurations which explicitly specify t

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-22 Thread Cleber Rosa
Yanan Wang writes: > In the SMP configuration, we should either specify a topology > parameter with a reasonable value (equal to or greater than 1) > or just leave it omitted and QEMU will calculate its value. > Configurations which explicitly specify the topology parameters > as zero like "sock

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-22 Thread Andrew Jones
On Thu, Jul 22, 2021 at 11:43:26PM +0800, Yanan Wang wrote: > In the SMP configuration, we should either specify a topology > parameter with a reasonable value (equal to or greater than 1) > or just leave it omitted and QEMU will calculate its value. > Configurations which explicitly specify the to

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-22 Thread Daniel P . Berrangé
On Thu, Jul 22, 2021 at 11:43:26PM +0800, Yanan Wang wrote: > In the SMP configuration, we should either specify a topology > parameter with a reasonable value (equal to or greater than 1) > or just leave it omitted and QEMU will calculate its value. > Configurations which explicitly specify the to

[PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-22 Thread Yanan Wang
In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU will calculate its value. Configurations which explicitly specify the topology parameters as zero like "sockets=0" are meaningless, so disal