Re: [PATCH for-6.1] tcg/i386: Split P_VEXW from P_REXW

2021-08-13 Thread Peter Maydell
On Fri, 13 Aug 2021 at 17:59, Richard Henderson wrote: > > On 8/13/21 12:37 AM, Peter Maydell wrote: > > These changes look OK as far as they go, but it's not clear to > > me why the other places that set P_REXW are all OK to use P_REXW > > and not P_VEXW. For instance tcg_out_mov() sets rexw = P_

Re: [PATCH for-6.1] tcg/i386: Split P_VEXW from P_REXW

2021-08-13 Thread Richard Henderson
On 8/13/21 6:59 AM, Richard Henderson wrote: On 8/13/21 12:37 AM, Peter Maydell wrote: These changes look OK as far as they go, but it's not clear to me why the other places that set P_REXW are all OK to use P_REXW and not P_VEXW. For instance tcg_out_mov() sets rexw = P_REXW and some of the cod

Re: [PATCH for-6.1] tcg/i386: Split P_VEXW from P_REXW

2021-08-13 Thread Richard Henderson
On 8/13/21 12:37 AM, Peter Maydell wrote: These changes look OK as far as they go, but it's not clear to me why the other places that set P_REXW are all OK to use P_REXW and not P_VEXW. For instance tcg_out_mov() sets rexw = P_REXW and some of the codepaths there will then pass that into tcg_out_

Re: [PATCH for-6.1] tcg/i386: Split P_VEXW from P_REXW

2021-08-13 Thread Peter Maydell
On Wed, 11 Aug 2021 at 00:26, Richard Henderson wrote: > > We need to be able to represent VEX.W on a 32-bit host, where REX.W > will always be zero. Fixes the encoding for VPSLLVQ and VPSRLVQ. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/385 > Signed-off-by: Richard Henderson > -

Re: [PATCH for-6.1] tcg/i386: Split P_VEXW from P_REXW

2021-08-13 Thread Peter Maydell
On Wed, 11 Aug 2021 at 00:26, Richard Henderson wrote: > > We need to be able to represent VEX.W on a 32-bit host, where REX.W > will always be zero. Fixes the encoding for VPSLLVQ and VPSRLVQ. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/385 > Signed-off-by: Richard Henderson Th

Re: [PATCH for-6.1] tcg/i386: Split P_VEXW from P_REXW

2021-08-12 Thread Peter Maydell
On Thu, 12 Aug 2021 at 19:29, Richard Henderson wrote: > > PIng for review, or this slips to 6.2. > > On 8/10/21 1:25 PM, Richard Henderson wrote: > > We need to be able to represent VEX.W on a 32-bit host, where REX.W > > will always be zero. Fixes the encoding for VPSLLVQ and VPSRLVQ. > > > > R

Re: [PATCH for-6.1] tcg/i386: Split P_VEXW from P_REXW

2021-08-12 Thread Richard Henderson
PIng for review, or this slips to 6.2. On 8/10/21 1:25 PM, Richard Henderson wrote: We need to be able to represent VEX.W on a 32-bit host, where REX.W will always be zero. Fixes the encoding for VPSLLVQ and VPSRLVQ. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/385 Signed-off-by: Ri

[PATCH for-6.1] tcg/i386: Split P_VEXW from P_REXW

2021-08-10 Thread Richard Henderson
We need to be able to represent VEX.W on a 32-bit host, where REX.W will always be zero. Fixes the encoding for VPSLLVQ and VPSRLVQ. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/385 Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 13 +++-- 1 file changed, 7 i