Re: [PATCH for-5.2] spapr: Simplify error handling in spapr_phb_realize()

2020-07-20 Thread David Gibson
On Mon, Jul 20, 2020 at 11:29:06AM +0200, Markus Armbruster wrote: > Greg Kurz writes: > > > The spapr_phb_realize() function has a local_err variable which > > is used to: > > > > 1) check failures of spapr_irq_findone() and spapr_irq_claim() > > > > 2) prepend extra information to the error mes

Re: [PATCH for-5.2] spapr: Simplify error handling in spapr_phb_realize()

2020-07-20 Thread Markus Armbruster
Greg Kurz writes: > The spapr_phb_realize() function has a local_err variable which > is used to: > > 1) check failures of spapr_irq_findone() and spapr_irq_claim() > > 2) prepend extra information to the error message > > Recent work from Markus Armbruster highlighted we get better > code when t

[PATCH for-5.2] spapr: Simplify error handling in spapr_phb_realize()

2020-07-17 Thread Greg Kurz
The spapr_phb_realize() function has a local_err variable which is used to: 1) check failures of spapr_irq_findone() and spapr_irq_claim() 2) prepend extra information to the error message Recent work from Markus Armbruster highlighted we get better code when testing the return value of a functi