Re: [PATCH for-5.1 2/2] hw: Mark nd_table[] misuse in realize methods FIXME

2020-07-15 Thread Niek Linnenbank
On Wed, Jul 15, 2020, 16:04 Markus Armbruster wrote: > nd_table[] contains NIC configuration for boards to pick up. Device > code has no business looking there. Several devices do it anyway. > Two of them already have a suitable FIXME comment: "allwinner-a10" and > "msf2-soc". Copy it to the o

Re: [PATCH for-5.1 2/2] hw: Mark nd_table[] misuse in realize methods FIXME

2020-07-15 Thread Alistair Francis
On Wed, Jul 15, 2020 at 7:06 AM Markus Armbruster wrote: > > nd_table[] contains NIC configuration for boards to pick up. Device > code has no business looking there. Several devices do it anyway. > Two of them already have a suitable FIXME comment: "allwinner-a10" and > "msf2-soc". Copy it to

Re: [PATCH for-5.1 2/2] hw: Mark nd_table[] misuse in realize methods FIXME

2020-07-15 Thread Markus Armbruster
Thomas Huth writes: > On 15/07/2020 16.04, Markus Armbruster wrote: >> nd_table[] contains NIC configuration for boards to pick up. Device >> code has no business looking there. Several devices do it anyway. >> Two of them already have a suitable FIXME comment: "allwinner-a10" and >> "msf2-soc"

Re: [PATCH for-5.1 2/2] hw: Mark nd_table[] misuse in realize methods FIXME

2020-07-15 Thread Thomas Huth
On 15/07/2020 16.04, Markus Armbruster wrote: > nd_table[] contains NIC configuration for boards to pick up. Device > code has no business looking there. Several devices do it anyway. > Two of them already have a suitable FIXME comment: "allwinner-a10" and > "msf2-soc". Copy it to the others: "a

[PATCH for-5.1 2/2] hw: Mark nd_table[] misuse in realize methods FIXME

2020-07-15 Thread Markus Armbruster
nd_table[] contains NIC configuration for boards to pick up. Device code has no business looking there. Several devices do it anyway. Two of them already have a suitable FIXME comment: "allwinner-a10" and "msf2-soc". Copy it to the others: "allwinner-h3", "xlnx-versal", "xlnx,zynqmp", "sparc32-l