Re: [PATCH for-5.1] xhci: fix valid.max_access_size to access address registers

2020-07-21 Thread Gerd Hoffmann
Hi, > >> -.valid.max_access_size = 4, > >> +.valid.max_access_size = sizeof(dma_addr_t), > I don't think it's needed as AC64 (in fact a bit in HCCPARAMS) is set > only if sizeof(dma_addr_t) != 4... So both AC64 bit and max_access_size are in sync, good. Patch queued. thanks, Gerd

Re: [PATCH for-5.1] xhci: fix valid.max_access_size to access address registers

2020-07-21 Thread Laurent Vivier
On 21/07/2020 11:17, Philippe Mathieu-Daudé wrote: > On 7/21/20 10:33 AM, Laurent Vivier wrote: >> QEMU XHCI advertises AC64 (64-bit addressing) but doesn't allow >> 64-bit mode access in "runtime" and "operational" MemoryRegionOps. >> >> Set the max_access_size based on sizeof(dma_addr_t) as AC64

Re: [PATCH for-5.1] xhci: fix valid.max_access_size to access address registers

2020-07-21 Thread Philippe Mathieu-Daudé
On 7/21/20 10:33 AM, Laurent Vivier wrote: > QEMU XHCI advertises AC64 (64-bit addressing) but doesn't allow > 64-bit mode access in "runtime" and "operational" MemoryRegionOps. > > Set the max_access_size based on sizeof(dma_addr_t) as AC64 is set. > > XHCI specs: > "If the xHC supports 64-bit a

[PATCH for-5.1] xhci: fix valid.max_access_size to access address registers

2020-07-21 Thread Laurent Vivier
QEMU XHCI advertises AC64 (64-bit addressing) but doesn't allow 64-bit mode access in "runtime" and "operational" MemoryRegionOps. Set the max_access_size based on sizeof(dma_addr_t) as AC64 is set. XHCI specs: "If the xHC supports 64-bit addressing (AC64 = ‘1’), then software should write 64-bit