Re: [PATCH for-10.1 15/32] vfio: Introduce a new header file for helper services

2025-03-21 Thread John Levon
On Fri, Mar 21, 2025 at 10:25:15AM +0100, Cédric Le Goater wrote: > > > +struct vfio_info_cap_header * > > > +vfio_get_region_info_cap(struct vfio_region_info *info, uint16_t id); > > > > This can be static in fact. > > It is used by vfio_device_get_region_info_type() and > vfio_device_has_regio

Re: [PATCH for-10.1 15/32] vfio: Introduce a new header file for helper services

2025-03-21 Thread Cédric Le Goater
On 3/20/25 10:40, John Levon wrote: On Tue, Mar 18, 2025 at 10:53:58AM +0100, Cédric Le Goater wrote: Gather all helper routine declarations into "helpers.h" to reduce exposure of VFIO internals in "hw/vfio/vfio-common.h". Signed-off-by: Cédric Le Goater Reviewed-by: John Levon but +str

Re: [PATCH for-10.1 15/32] vfio: Introduce a new header file for helper services

2025-03-20 Thread John Levon
On Tue, Mar 18, 2025 at 10:53:58AM +0100, Cédric Le Goater wrote: > Gather all helper routine declarations into "helpers.h" to reduce > exposure of VFIO internals in "hw/vfio/vfio-common.h". > > Signed-off-by: Cédric Le Goater Reviewed-by: John Levon but > +struct vfio_info_cap_header * > +v

[PATCH for-10.1 15/32] vfio: Introduce a new header file for helper services

2025-03-18 Thread Cédric Le Goater
Gather all helper routine declarations into "helpers.h" to reduce exposure of VFIO internals in "hw/vfio/vfio-common.h". Signed-off-by: Cédric Le Goater --- hw/vfio/helpers.h | 26 ++ include/hw/vfio/vfio-common.h | 7 --- hw/s390x/s390-pci-vfio.c |