Re: [PATCH V7 02/12] cpus: stop vm in suspended runstate

2023-12-11 Thread Steven Sistare
Hi Markus, Eric, any comment about this change in stop/cont behavior before it gets pulled? There is no change since V6. - Steve On 12/6/2023 12:23 PM, Steve Sistare wrote: > Currently, a vm in the suspended state is not completely stopped. The VCPUs > have been paused, but the cpu clock still

Re: [PATCH V7 02/12] cpus: stop vm in suspended runstate

2023-12-10 Thread Peter Xu
On Wed, Dec 06, 2023 at 10:09:32PM +0100, Philippe Mathieu-Daudé wrote: > What about runstate_is_vcpu_clock_ticking() then? The problem is vCPU clock ticks can only be one part of "VM is running" state (no matter whether vCPUs are running or not). I'm even thinking whether cpu_enable_ticks() shou

Re: [PATCH V7 02/12] cpus: stop vm in suspended runstate

2023-12-06 Thread Philippe Mathieu-Daudé
On 6/12/23 21:48, Philippe Mathieu-Daudé wrote: On 6/12/23 20:19, Steven Sistare wrote: On 12/6/2023 1:45 PM, Philippe Mathieu-Daudé wrote: Hi Steve, On 6/12/23 18:23, Steve Sistare wrote: Currently, a vm in the suspended state is not completely stopped. The VCPUs have been paused, but the c

Re: [PATCH V7 02/12] cpus: stop vm in suspended runstate

2023-12-06 Thread Philippe Mathieu-Daudé
On 6/12/23 20:19, Steven Sistare wrote: On 12/6/2023 1:45 PM, Philippe Mathieu-Daudé wrote: Hi Steve, On 6/12/23 18:23, Steve Sistare wrote: Currently, a vm in the suspended state is not completely stopped.  The VCPUs have been paused, but the cpu clock still runs, and runstate notifiers for t

Re: [PATCH V7 02/12] cpus: stop vm in suspended runstate

2023-12-06 Thread Steven Sistare
On 12/6/2023 1:45 PM, Philippe Mathieu-Daudé wrote: > Hi Steve, > > On 6/12/23 18:23, Steve Sistare wrote: >> Currently, a vm in the suspended state is not completely stopped.  The VCPUs >> have been paused, but the cpu clock still runs, and runstate notifiers for >> the transition to stopped have

Re: [PATCH V7 02/12] cpus: stop vm in suspended runstate

2023-12-06 Thread Philippe Mathieu-Daudé
Hi Steve, On 6/12/23 18:23, Steve Sistare wrote: Currently, a vm in the suspended state is not completely stopped. The VCPUs have been paused, but the cpu clock still runs, and runstate notifiers for the transition to stopped have not been called. This causes problems for live migration. Stal

[PATCH V7 02/12] cpus: stop vm in suspended runstate

2023-12-06 Thread Steve Sistare
Currently, a vm in the suspended state is not completely stopped. The VCPUs have been paused, but the cpu clock still runs, and runstate notifiers for the transition to stopped have not been called. This causes problems for live migration. Stale cpu timers_state is saved to the migration stream,

[PATCH V7 02/12] cpus: stop vm in suspended runstate

2023-12-06 Thread Steve Sistare
Currently, a vm in the suspended state is not completely stopped. The VCPUs have been paused, but the cpu clock still runs, and runstate notifiers for the transition to stopped have not been called. This causes problems for live migration. Stale cpu timers_state is saved to the migration stream,