Re: [PATCH V7 00/12] fix migration of suspended runstate

2023-12-12 Thread Peter Xu
On Mon, Dec 11, 2023 at 08:31:17AM -0500, Steven Sistare wrote: > On 12/11/2023 1:56 AM, Peter Xu wrote: > > On Wed, Dec 06, 2023 at 12:30:02PM -0500, Steven Sistare wrote: > >> cpus: stop vm in suspended runstate > > > > This patch still didn't copy the QAPI maintainers, please remember to do

Re: [PATCH V7 00/12] fix migration of suspended runstate

2023-12-11 Thread Steven Sistare
On 12/11/2023 1:56 AM, Peter Xu wrote: > On Wed, Dec 06, 2023 at 12:30:02PM -0500, Steven Sistare wrote: >> cpus: stop vm in suspended runstate > > This patch still didn't copy the QAPI maintainers, please remember to do so > in a new post. > > Maybe it would be easier to move the QAPI doc ch

Re: [PATCH V7 00/12] fix migration of suspended runstate

2023-12-10 Thread Peter Xu
On Wed, Dec 06, 2023 at 12:30:02PM -0500, Steven Sistare wrote: > cpus: stop vm in suspended runstate This patch still didn't copy the QAPI maintainers, please remember to do so in a new post. Maybe it would be easier to move the QAPI doc changes into a separate patch? Thanks, -- Peter Xu

Re: [PATCH V7 00/12] fix migration of suspended runstate

2023-12-06 Thread Steven Sistare
FYI, these patches still need RB: migration: propagate suspended runstate tests/qtest: precopy migration with suspend tests/qtest: postcopy migration with suspend This has RB, but the interaction between vm_start and vm_prepare_start changed, so needs another look. cpus: stop vm in suspe

[PATCH V7 00/12] fix migration of suspended runstate

2023-12-06 Thread Steve Sistare
Migration of a guest in the suspended runstate is broken. The incoming migration code automatically tries to wake the guest, which is wrong; the guest should end migration in the same runstate it started. Further, after saving a snapshot in the suspended state and loading it, the vm_start fails.

Re: [PATCH V7 00/12] fix migration of suspended runstate

2023-12-06 Thread Steven Sistare
Gack, there was cruft in my send mail directory. Please ignore this threaded series, and I will resend. Sorry for the noise. - Steve On 12/6/2023 12:12 PM, Steve Sistare wrote: > Migration of a guest in the suspended runstate is broken. The incoming > migration code automatically tries to wak

[PATCH V7 00/12] fix migration of suspended runstate

2023-12-06 Thread Steve Sistare
Migration of a guest in the suspended runstate is broken. The incoming migration code automatically tries to wake the guest, which is wrong; the guest should end migration in the same runstate it started. Further, after saving a snapshot in the suspended state and loading it, the vm_start fails.