Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-28 Thread Steven Sistare
On 11/22/2023 11:21 AM, Peter Xu wrote: > On Wed, Nov 22, 2023 at 09:38:06AM +, Daniel P. Berrangé wrote: >> On Mon, Nov 20, 2023 at 04:44:50PM -0500, Peter Xu wrote: >>> On Mon, Nov 20, 2023 at 03:55:54PM -0500, Steven Sistare wrote: If we drop force, then all calls to vm_stop will comple

Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-22 Thread Peter Xu
On Wed, Nov 22, 2023 at 09:38:06AM +, Daniel P. Berrangé wrote: > On Mon, Nov 20, 2023 at 04:44:50PM -0500, Peter Xu wrote: > > On Mon, Nov 20, 2023 at 03:55:54PM -0500, Steven Sistare wrote: > > > If we drop force, then all calls to vm_stop will completely stop the > > > suspended state, eg an

Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-22 Thread Daniel P . Berrangé
On Mon, Nov 20, 2023 at 04:44:50PM -0500, Peter Xu wrote: > On Mon, Nov 20, 2023 at 03:55:54PM -0500, Steven Sistare wrote: > > If we drop force, then all calls to vm_stop will completely stop the > > suspended state, eg an hmp "stop" command. This causes two problems. > > First, that is a change i

Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-21 Thread Peter Xu
On Tue, Nov 21, 2023 at 04:21:18PM -0500, Steven Sistare wrote: > On 11/20/2023 4:44 PM, Peter Xu wrote: > > On Mon, Nov 20, 2023 at 03:55:54PM -0500, Steven Sistare wrote: > >> If we drop force, then all calls to vm_stop will completely stop the > >> suspended state, eg an hmp "stop" command. This

Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-21 Thread Steven Sistare
On 11/20/2023 4:44 PM, Peter Xu wrote: > On Mon, Nov 20, 2023 at 03:55:54PM -0500, Steven Sistare wrote: >> If we drop force, then all calls to vm_stop will completely stop the >> suspended state, eg an hmp "stop" command. This causes two problems. >> First, that is a change in user-visible behavio

Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-20 Thread Peter Xu
On Mon, Nov 20, 2023 at 03:55:54PM -0500, Steven Sistare wrote: > If we drop force, then all calls to vm_stop will completely stop the > suspended state, eg an hmp "stop" command. This causes two problems. > First, that is a change in user-visible behavior for something that > currently works, IMH

Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-20 Thread Steven Sistare
On 11/20/2023 3:47 PM, Fabiano Rosas wrote: > Peter Xu writes: >> On Mon, Nov 13, 2023 at 10:33:50AM -0800, Steve Sistare wrote: >>> A vm in the suspended state is not completely stopped. The VCPUs have been >>> paused, but the cpu clock still runs, and runstate notifiers for the >>> transition t

Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-20 Thread Steven Sistare
On 11/20/2023 2:59 PM, Peter Xu wrote: > On Mon, Nov 13, 2023 at 10:33:50AM -0800, Steve Sistare wrote: >> A vm in the suspended state is not completely stopped. The VCPUs have been >> paused, but the cpu clock still runs, and runstate notifiers for the >> transition to stopped have not been calle

Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-20 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Nov 13, 2023 at 10:33:50AM -0800, Steve Sistare wrote: >> A vm in the suspended state is not completely stopped. The VCPUs have been >> paused, but the cpu clock still runs, and runstate notifiers for the >> transition to stopped have not been called. Modify vm_stop_f

Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-20 Thread Peter Xu
On Mon, Nov 13, 2023 at 10:33:50AM -0800, Steve Sistare wrote: > A vm in the suspended state is not completely stopped. The VCPUs have been > paused, but the cpu clock still runs, and runstate notifiers for the > transition to stopped have not been called. Modify vm_stop_force_state to > complete

Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-20 Thread Steven Sistare
On 11/20/2023 9:15 AM, Fabiano Rosas wrote: > Steve Sistare writes: > >> A vm in the suspended state is not completely stopped. > > Is this a statement of a fact about VMs in the suspended state in > general or is this describing what this patch is trying to fix? The former. >> The VCPUs hav

Re: [PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-20 Thread Fabiano Rosas
Steve Sistare writes: > A vm in the suspended state is not completely stopped. Is this a statement of a fact about VMs in the suspended state in general or is this describing what this patch is trying to fix? > The VCPUs have been paused, but the cpu clock still runs, and runstate > notifiers

[PATCH V5 02/12] cpus: stop vm in suspended state

2023-11-13 Thread Steve Sistare
A vm in the suspended state is not completely stopped. The VCPUs have been paused, but the cpu clock still runs, and runstate notifiers for the transition to stopped have not been called. Modify vm_stop_force_state to completely stop the vm if the current state is suspended, to be called for live