Re: [PATCH V4 5/5] migration: simplify exec migration functions

2024-02-21 Thread Steven Sistare
On 2/21/2024 10:54 AM, Fabiano Rosas wrote: > Fabiano Rosas writes: > >> Steve Sistare writes: >> >>> Simplify the exec migration code by using list utility functions. >>> >>> As a side effect, this also fixes a minor memory leak. On function return, >>> "g_auto(GStrv) argv" frees argv and each

Re: [PATCH V4 5/5] migration: simplify exec migration functions

2024-02-21 Thread Fabiano Rosas
Fabiano Rosas writes: > Steve Sistare writes: > >> Simplify the exec migration code by using list utility functions. >> >> As a side effect, this also fixes a minor memory leak. On function return, >> "g_auto(GStrv) argv" frees argv and each element, which is wrong, because >> the function does

Re: [PATCH V4 5/5] migration: simplify exec migration functions

2024-02-21 Thread Markus Armbruster
Het Gala, Peter, or Fabiano, please review. Steve Sistare writes: > Simplify the exec migration code by using list utility functions. > > As a side effect, this also fixes a minor memory leak. On function return, > "g_auto(GStrv) argv" frees argv and each element, which is wrong, because > the

Re: [PATCH V4 5/5] migration: simplify exec migration functions

2024-02-21 Thread Fabiano Rosas
Steve Sistare writes: > Simplify the exec migration code by using list utility functions. > > As a side effect, this also fixes a minor memory leak. On function return, > "g_auto(GStrv) argv" frees argv and each element, which is wrong, because > the function does not own the individual elements

[PATCH V4 5/5] migration: simplify exec migration functions

2024-01-12 Thread Steve Sistare
Simplify the exec migration code by using list utility functions. As a side effect, this also fixes a minor memory leak. On function return, "g_auto(GStrv) argv" frees argv and each element, which is wrong, because the function does not own the individual elements. To compensate, the code uses g