> -Original Message-
> From: Markus Armbruster
> Sent: Wednesday, March 24, 2021 2:47 PM
> To: Dr. David Alan Gilbert
> Cc: Lukas Straub ; Li Zhijian
> ; Jason Wang ; qemu-
> dev ; Zhang, Chen ;
> Zhang Chen
> Subject: Re: [PATCH V4 2/7] qapi/net.json: A
Zhang Chen writes:
> Add L4_Connection struct for other QMP commands.
> Except protocol field is necessary, other fields are optional.
>
> Signed-off-by: Zhang Chen
> ---
> qapi/net.json | 26 ++
> 1 file changed, 26 insertions(+)
>
> diff --git a/qapi/net.json b/qapi/ne
Markus Armbruster writes:
> "Dr. David Alan Gilbert" writes:
[...]
>> I think there should also beb
>> a separate type that represents an IP address+port, so that what you end
>> up with is:
>>
>> IPFlowSpec
>> ID
>> Protocol
>> Source
>>
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> "Zhang, Chen" writes:
>>
>> >> -Original Message-
>> >> From: Markus Armbruster
>> [...]
>> >> Naming the argument type L4_Connection is misleading.
>> >>
>> >> Even naming the match arguments L4_Conn
> -Original Message-
> From: Markus Armbruster
> Sent: Tuesday, March 23, 2021 5:55 PM
> To: Zhang, Chen
> Cc: Lukas Straub ; Li Zhijian
> ; Jason Wang ; qemu-
> dev ; Dr. David Alan Gilbert
> ; Zhang Chen
> Subject: Re: [PATCH V4 2/7] qapi/net.json: A
* Markus Armbruster (arm...@redhat.com) wrote:
> "Zhang, Chen" writes:
>
> >> -Original Message-
> >> From: Markus Armbruster
> [...]
> >> Naming the argument type L4_Connection is misleading.
> >>
> >> Even naming the match arguments L4_Connection would be misleading.
> >> "Connection"
"Zhang, Chen" writes:
>> -Original Message-
>> From: Markus Armbruster
[...]
>> Naming the argument type L4_Connection is misleading.
>>
>> Even naming the match arguments L4_Connection would be misleading.
>> "Connection" has a specific meaning in networking. There are TCP
>> connecti
> -Original Message-
> From: Markus Armbruster
> Sent: Monday, March 22, 2021 8:31 PM
> To: Zhang, Chen
> Cc: Lukas Straub ; Li Zhijian
> ; Jason Wang ; qemu-
> dev ; Dr. David Alan Gilbert
> ; Zhang Chen
> Subject: Re: [PATCH V4 2/7] qapi/net.json: A
uster ;
>> Li Zhijian ; Lukas Straub ;
>> Zhang Chen
>> Subject: Re: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition
>>
>> Zhang Chen writes:
>>
>> > Add L4_Connection struct for other QMP commands.
>> > Except protocol field is ne
gt; Subject: Re: [PATCH V4 2/7] qapi/net.json: Add L4_Connection definition
>
> Zhang Chen writes:
>
> > Add L4_Connection struct for other QMP commands.
> > Except protocol field is necessary, other fields are optional.
> >
> > Signed-off-by: Zhang Chen
> &g
One more little thing...
Zhang Chen writes:
> Add L4_Connection struct for other QMP commands.
> Except protocol field is necessary, other fields are optional.
>
> Signed-off-by: Zhang Chen
> ---
> qapi/net.json | 26 ++
> 1 file changed, 26 insertions(+)
>
> diff --git
Zhang Chen writes:
> Add L4_Connection struct for other QMP commands.
> Except protocol field is necessary, other fields are optional.
>
> Signed-off-by: Zhang Chen
> ---
> qapi/net.json | 26 ++
> 1 file changed, 26 insertions(+)
>
> diff --git a/qapi/net.json b/qapi/ne
Add L4_Connection struct for other QMP commands.
Except protocol field is necessary, other fields are optional.
Signed-off-by: Zhang Chen
---
qapi/net.json | 26 ++
1 file changed, 26 insertions(+)
diff --git a/qapi/net.json b/qapi/net.json
index 498ea7aa72..cd4a8ed95e 1
13 matches
Mail list logo
