Re: [PATCH V4 10/14] migration: stop vm for cpr

2024-03-13 Thread Cédric Le Goater
On 3/13/24 15:18, Steven Sistare wrote: On 2/29/2024 8:28 PM, Peter Xu wrote: On Thu, Feb 29, 2024 at 10:21:14AM -0500, Steven Sistare wrote: On 2/25/2024 9:08 PM, Peter Xu wrote: On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: When migration for cpr is initiated, stop the vm a

Re: [PATCH V4 10/14] migration: stop vm for cpr

2024-03-13 Thread Steven Sistare
On 2/29/2024 8:28 PM, Peter Xu wrote: On Thu, Feb 29, 2024 at 10:21:14AM -0500, Steven Sistare wrote: On 2/25/2024 9:08 PM, Peter Xu wrote: On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: When migration for cpr is initiated, stop the vm and set state RUN_STATE_FINISH_MIGRATE bef

Re: [PATCH V4 10/14] migration: stop vm for cpr

2024-03-01 Thread Cédric Le Goater
On 3/1/24 02:28, Peter Xu wrote: On Thu, Feb 29, 2024 at 10:21:14AM -0500, Steven Sistare wrote: On 2/25/2024 9:08 PM, Peter Xu wrote: On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: When migration for cpr is initiated, stop the vm and set state RUN_STATE_FINISH_MIGRATE before r

Re: [PATCH V4 10/14] migration: stop vm for cpr

2024-02-29 Thread Peter Xu
On Thu, Feb 29, 2024 at 10:21:14AM -0500, Steven Sistare wrote: > On 2/25/2024 9:08 PM, Peter Xu wrote: > > On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: > >> When migration for cpr is initiated, stop the vm and set state > >> RUN_STATE_FINISH_MIGRATE before ram is saved. This eli

Re: [PATCH V4 10/14] migration: stop vm for cpr

2024-02-29 Thread Steven Sistare
On 2/25/2024 9:08 PM, Peter Xu wrote: > On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: >> When migration for cpr is initiated, stop the vm and set state >> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the >> possibility of ram and device state being out of sync, an

Re: [PATCH V4 10/14] migration: stop vm for cpr

2024-02-25 Thread Peter Xu
On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: > When migration for cpr is initiated, stop the vm and set state > RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the > possibility of ram and device state being out of sync, and guarantees > that a guest in the suspende

[PATCH V4 10/14] migration: stop vm for cpr

2024-02-22 Thread Steve Sistare
When migration for cpr is initiated, stop the vm and set state RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the possibility of ram and device state being out of sync, and guarantees that a guest in the suspended state remains suspended, because qmp_cont rejects a cont command in t