Re: [PATCH V3 4/4] intel-iommu: PASID support

2022-10-17 Thread Jason Wang
On Mon, Oct 17, 2022 at 11:13 PM Peter Xu wrote: > > On Mon, Oct 17, 2022 at 03:52:46PM +0800, Jason Wang wrote: > > [...] > > > > > +struct vtd_iotlb_key { > > > > +uint16_t sid; > > > > +uint32_t pasid; > > > > +uint64_t gfn; > > > > +uint32_t level; > > > > }; > > > > > > Nit:

Re: [PATCH V3 4/4] intel-iommu: PASID support

2022-10-17 Thread Peter Xu
On Mon, Oct 17, 2022 at 03:52:46PM +0800, Jason Wang wrote: [...] > > > +struct vtd_iotlb_key { > > > +uint16_t sid; > > > +uint32_t pasid; > > > +uint64_t gfn; > > > +uint32_t level; > > > }; > > > > Nit: maybe re-arrange it a bit? > > > >struct vtd_iotlb_key { > >ui

Re: [PATCH V3 4/4] intel-iommu: PASID support

2022-10-17 Thread Jason Wang
On Sat, Oct 15, 2022 at 12:17 AM Peter Xu wrote: > > On Sun, Oct 09, 2022 at 01:48:35PM +0800, Jason Wang wrote: > > This patch introduce ECAP_PASID via "x-pasid-mode". Based on the > > existing support for scalable mode, we need to implement the following > > missing parts: > > > > 1) tag VTDAddr

Re: [PATCH V3 4/4] intel-iommu: PASID support

2022-10-14 Thread Peter Xu
On Sun, Oct 09, 2022 at 01:48:35PM +0800, Jason Wang wrote: > This patch introduce ECAP_PASID via "x-pasid-mode". Based on the > existing support for scalable mode, we need to implement the following > missing parts: > > 1) tag VTDAddressSpace with PASID and support IOMMU/DMA translation >with

[PATCH V3 4/4] intel-iommu: PASID support

2022-10-08 Thread Jason Wang
This patch introduce ECAP_PASID via "x-pasid-mode". Based on the existing support for scalable mode, we need to implement the following missing parts: 1) tag VTDAddressSpace with PASID and support IOMMU/DMA translation with PASID 2) tag IOTLB with PASID 3) PASID cache and its flush 4) PASID bas