Re: [PATCH V3 2/2] migration: file URI offset

2023-06-30 Thread Steven Sistare
On 6/29/2023 5:38 PM, Peter Xu wrote: > On Thu, Jun 22, 2023 at 01:37:31PM -0700, Steve Sistare wrote: >> +static int file_parse_offset(char *filespec, uint64_t *offsetp, Error >> **errp) >> +{ >> +char *option = strstr(filespec, OFFSET_OPTION); >> +int ret; >> + >> +if (option) { >> +

Re: [PATCH V3 2/2] migration: file URI offset

2023-06-29 Thread Peter Xu
On Thu, Jun 22, 2023 at 01:37:31PM -0700, Steve Sistare wrote: > +static int file_parse_offset(char *filespec, uint64_t *offsetp, Error **errp) > +{ > +char *option = strstr(filespec, OFFSET_OPTION); > +int ret; > + > +if (option) { > +*option = 0; > +option += sizeof(OF

Re: [PATCH V3 2/2] migration: file URI offset

2023-06-28 Thread Peter Xu
On Thu, Jun 22, 2023 at 01:37:31PM -0700, Steve Sistare wrote: > Allow an offset option to be specified as part of the file URI, in > the form "file:filename,offset=offset", where offset accepts the common > size suffixes, or the 0x prefix, but not both. Migration data is written > to and read fro

[PATCH V3 2/2] migration: file URI offset

2023-06-22 Thread Steve Sistare
Allow an offset option to be specified as part of the file URI, in the form "file:filename,offset=offset", where offset accepts the common size suffixes, or the 0x prefix, but not both. Migration data is written to and read from the file starting at offset. If unspecified, it defaults to 0. This