Re: [PATCH V3 10/13] migration: stop vm for cpr

2024-02-22 Thread Steven Sistare
On 2/22/2024 4:30 AM, Peter Xu wrote: > On Thu, Feb 22, 2024 at 05:12:53PM +0800, Peter Xu wrote: >> On Wed, Feb 21, 2024 at 04:20:07PM -0500, Steven Sistare wrote: >>> On 2/20/2024 2:33 AM, Peter Xu wrote: On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote: > When migration for

Re: [PATCH V3 10/13] migration: stop vm for cpr

2024-02-22 Thread Steven Sistare
On 2/22/2024 4:03 AM, Peter Xu wrote: > On Wed, Feb 21, 2024 at 04:23:07PM -0500, Steven Sistare wrote: >>> How about postcopy? I know it's nonsense to enable postcopy for cpr.. but >>> iiuc we don't yet forbid an user doing so. Maybe we should? >> >> How about this? >> >> ---

Re: [PATCH V3 10/13] migration: stop vm for cpr

2024-02-22 Thread Peter Xu
On Thu, Feb 22, 2024 at 05:12:53PM +0800, Peter Xu wrote: > On Wed, Feb 21, 2024 at 04:20:07PM -0500, Steven Sistare wrote: > > On 2/20/2024 2:33 AM, Peter Xu wrote: > > > On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote: > > >> When migration for cpr is initiated, stop the vm and set

Re: [PATCH V3 10/13] migration: stop vm for cpr

2024-02-22 Thread Peter Xu
On Wed, Feb 21, 2024 at 04:20:07PM -0500, Steven Sistare wrote: > On 2/20/2024 2:33 AM, Peter Xu wrote: > > On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote: > >> When migration for cpr is initiated, stop the vm and set state > >> RUN_STATE_FINISH_MIGRATE before ram is saved. This eli

Re: [PATCH V3 10/13] migration: stop vm for cpr

2024-02-22 Thread Peter Xu
On Wed, Feb 21, 2024 at 04:23:07PM -0500, Steven Sistare wrote: > > How about postcopy? I know it's nonsense to enable postcopy for cpr.. but > > iiuc we don't yet forbid an user doing so. Maybe we should? > > How about this? > > --- > @@ -3600,6 +3600,11

Re: [PATCH V3 10/13] migration: stop vm for cpr

2024-02-21 Thread Steven Sistare
On 2/20/2024 2:33 AM, Peter Xu wrote: > On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote: >> When migration for cpr is initiated, stop the vm and set state >> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the >> possibility of ram and device state being out of sync, an

Re: [PATCH V3 10/13] migration: stop vm for cpr

2024-02-21 Thread Steven Sistare
On 2/20/2024 2:33 AM, Peter Xu wrote: > On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote: >> When migration for cpr is initiated, stop the vm and set state >> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the >> possibility of ram and device state being out of sync, an

Re: [PATCH V3 10/13] migration: stop vm for cpr

2024-02-20 Thread Steven Sistare
On 2/20/2024 2:33 AM, Peter Xu wrote: > On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote: >> When migration for cpr is initiated, stop the vm and set state >> RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the >> possibility of ram and device state being out of sync, an

Re: [PATCH V3 10/13] migration: stop vm for cpr

2024-02-19 Thread Peter Xu
On Thu, Feb 08, 2024 at 10:54:03AM -0800, Steve Sistare wrote: > When migration for cpr is initiated, stop the vm and set state > RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the > possibility of ram and device state being out of sync, and guarantees > that a guest in the suspende

[PATCH V3 10/13] migration: stop vm for cpr

2024-02-08 Thread Steve Sistare
When migration for cpr is initiated, stop the vm and set state RUN_STATE_FINISH_MIGRATE before ram is saved. This eliminates the possibility of ram and device state being out of sync, and guarantees that a guest in the suspended state remains suspended, because qmp_cont rejects a cont command in t