Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread Pan Nengyuan
On 2019/12/4 15:19, Vladimir Sementsov-Ogievskiy wrote: > 04.12.2019 6:12, pannengyuan wrote: >> >> >> On 2019/12/4 1:38, Vladimir Sementsov-Ogievskiy wrote: >>> Hi! >>> >>> First, please, when sending more than one patch, create a cover-letter. >>> Also, >>> summarize (in cover letter) what wa

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
04.12.2019 6:12, pannengyuan wrote: > > > On 2019/12/4 1:38, Vladimir Sementsov-Ogievskiy wrote: >> Hi! >> >> First, please, when sending more than one patch, create a cover-letter. Also, >> summarize (in cover letter) what was changed since previous version. > In previous version, I only send on

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread pannengyuan
On 2019/12/4 3:00, Eric Blake wrote: > On 11/29/19 1:25 AM, pannengy...@huawei.com wrote: >> From: PanNengyuan >> >> The BDRVNBDState cleanup code is common in two places, add >> nbd_free_bdrvstate_prop() function to do these cleanups (suggested by >> Stefano Garzarella). >> >> Signed-off-by: P

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread pannengyuan
On 2019/12/4 1:38, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > First, please, when sending more than one patch, create a cover-letter. Also, > summarize (in cover letter) what was changed since previous version. In previous version, I only send one patch(2/2 in this version), so I only add a

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread Eric Blake
On 11/29/19 1:25 AM, pannengy...@huawei.com wrote: From: PanNengyuan The BDRVNBDState cleanup code is common in two places, add nbd_free_bdrvstate_prop() function to do these cleanups (suggested by Stefano Garzarella). Signed-off-by: PanNengyuan --- block/nbd.c | 23 +--

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
Hi! First, please, when sending more than one patch, create a cover-letter. Also, summarize (in cover letter) what was changed since previous version. 29.11.2019 10:25, pannengy...@huawei.com wrote: > From: PanNengyuan Strange line. Check you git preferences. Such line appears (and make sense)

[PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-11-28 Thread pannengyuan
From: PanNengyuan The BDRVNBDState cleanup code is common in two places, add nbd_free_bdrvstate_prop() function to do these cleanups (suggested by Stefano Garzarella). Signed-off-by: PanNengyuan --- block/nbd.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) di