Re: [PATCH V3 04/13] migration: MigrationEvent for notifiers

2024-02-19 Thread Peter Xu
On Thu, Feb 08, 2024 at 10:53:57AM -0800, Steve Sistare wrote: > Passing MigrationState to notifiers is unsound because they could access > unstable migration state internals or even modify the state. Instead, pass > the minimal info needed in a new MigrationEvent struct, which could be > extended

Re: [PATCH V3 04/13] migration: MigrationEvent for notifiers

2024-02-12 Thread David Hildenbrand
On 08.02.24 19:53, Steve Sistare wrote: Passing MigrationState to notifiers is unsound because they could access unstable migration state internals or even modify the state. Instead, pass the minimal info needed in a new MigrationEvent struct, which could be extended in the future if needed. Su

[PATCH V3 04/13] migration: MigrationEvent for notifiers

2024-02-08 Thread Steve Sistare
Passing MigrationState to notifiers is unsound because they could access unstable migration state internals or even modify the state. Instead, pass the minimal info needed in a new MigrationEvent struct, which could be extended in the future if needed. Suggested-by: Peter Xu Signed-off-by: Steve