Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-25 Thread Steven Sistare
On 10/25/2024 9:55 AM, Peter Xu wrote: On Thu, Oct 24, 2024 at 05:12:05PM -0400, Steven Sistare wrote: On 10/10/2024 5:23 PM, Peter Xu wrote: On Thu, Oct 10, 2024 at 04:06:13PM -0400, Steven Sistare wrote: vhost requires us to stop the vm early: qmp_migrate stop vm migration_ca

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-25 Thread Peter Xu
On Thu, Oct 24, 2024 at 05:12:05PM -0400, Steven Sistare wrote: > On 10/10/2024 5:23 PM, Peter Xu wrote: > > On Thu, Oct 10, 2024 at 04:06:13PM -0400, Steven Sistare wrote: > > > vhost requires us to stop the vm early: > > >qmp_migrate > > > stop vm > > > migration_call_notifiers MIG_

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-25 Thread Steven Sistare
On 10/10/2024 5:23 PM, Peter Xu wrote: On Thu, Oct 10, 2024 at 04:06:13PM -0400, Steven Sistare wrote: vhost requires us to stop the vm early: qmp_migrate stop vm migration_call_notifiers MIG_EVENT_PRECOPY_CPR_SETUP vhost_cpr_notifier vhost_reset_device - must be aft

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-10 Thread Peter Xu
On Thu, Oct 10, 2024 at 04:06:13PM -0400, Steven Sistare wrote: > vhost requires us to stop the vm early: > qmp_migrate > stop vm > migration_call_notifiers MIG_EVENT_PRECOPY_CPR_SETUP > vhost_cpr_notifier > vhost_reset_device - must be after stop vm >

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-10 Thread Steven Sistare
On 10/9/2024 4:36 PM, Peter Xu wrote: On Wed, Oct 09, 2024 at 04:09:45PM -0400, Steven Sistare wrote: On 10/9/2024 3:06 PM, Peter Xu wrote: On Wed, Oct 09, 2024 at 02:43:44PM -0400, Steven Sistare wrote: On 10/8/2024 3:48 PM, Peter Xu wrote: On Tue, Oct 08, 2024 at 04:11:38PM -0300, Fabiano R

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-10 Thread Steven Sistare
On 10/9/2024 6:08 PM, Fabiano Rosas wrote: Peter Xu writes: On Wed, Oct 09, 2024 at 04:18:31PM -0400, Steven Sistare wrote: Yes, I am also brainstorming along these lines, looking for more gotcha's, but its a big design change. I don't love it so far. These issues all creep in because of tra

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-09 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Oct 09, 2024 at 04:18:31PM -0400, Steven Sistare wrote: >> Yes, I am also brainstorming along these lines, looking for more gotcha's, >> but its a big design change. I don't love it so far. >> >> These issues all creep in because of transfer mode. Exec mode did not ha

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-09 Thread Peter Xu
On Wed, Oct 09, 2024 at 04:18:31PM -0400, Steven Sistare wrote: > Yes, I am also brainstorming along these lines, looking for more gotcha's, > but its a big design change. I don't love it so far. > > These issues all creep in because of transfer mode. Exec mode did not have > this > problem, as

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-09 Thread Peter Xu
On Wed, Oct 09, 2024 at 04:09:45PM -0400, Steven Sistare wrote: > On 10/9/2024 3:06 PM, Peter Xu wrote: > > On Wed, Oct 09, 2024 at 02:43:44PM -0400, Steven Sistare wrote: > > > On 10/8/2024 3:48 PM, Peter Xu wrote: > > > > On Tue, Oct 08, 2024 at 04:11:38PM -0300, Fabiano Rosas wrote: > > > > > As

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-09 Thread Steven Sistare
On 10/9/2024 3:59 PM, Peter Xu wrote: On Wed, Oct 09, 2024 at 03:06:53PM -0400, Peter Xu wrote: On Wed, Oct 09, 2024 at 02:43:44PM -0400, Steven Sistare wrote: On 10/8/2024 3:48 PM, Peter Xu wrote: On Tue, Oct 08, 2024 at 04:11:38PM -0300, Fabiano Rosas wrote: As of half an hour ago =) We cou

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-09 Thread Steven Sistare
On 10/9/2024 3:06 PM, Peter Xu wrote: On Wed, Oct 09, 2024 at 02:43:44PM -0400, Steven Sistare wrote: On 10/8/2024 3:48 PM, Peter Xu wrote: On Tue, Oct 08, 2024 at 04:11:38PM -0300, Fabiano Rosas wrote: As of half an hour ago =) We could put a feature branch up and work together, if you have m

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-09 Thread Peter Xu
On Wed, Oct 09, 2024 at 03:06:53PM -0400, Peter Xu wrote: > On Wed, Oct 09, 2024 at 02:43:44PM -0400, Steven Sistare wrote: > > On 10/8/2024 3:48 PM, Peter Xu wrote: > > > On Tue, Oct 08, 2024 at 04:11:38PM -0300, Fabiano Rosas wrote: > > > > As of half an hour ago =) We could put a feature branch

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-09 Thread Peter Xu
On Wed, Oct 09, 2024 at 02:43:44PM -0400, Steven Sistare wrote: > On 10/8/2024 3:48 PM, Peter Xu wrote: > > On Tue, Oct 08, 2024 at 04:11:38PM -0300, Fabiano Rosas wrote: > > > As of half an hour ago =) We could put a feature branch up and work > > > together, if you have more concrete thoughts on

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-09 Thread Steven Sistare
On 10/8/2024 3:48 PM, Peter Xu wrote: On Tue, Oct 08, 2024 at 04:11:38PM -0300, Fabiano Rosas wrote: As of half an hour ago =) We could put a feature branch up and work together, if you have more concrete thoughts on how this would look like let me know. [I'll hijack this thread with one more

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-08 Thread Peter Xu
On Tue, Oct 08, 2024 at 04:11:38PM -0300, Fabiano Rosas wrote: > As of half an hour ago =) We could put a feature branch up and work > together, if you have more concrete thoughts on how this would look like > let me know. [I'll hijack this thread with one more email, as this is not cpr-relevant]

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-08 Thread Peter Xu
On Tue, Oct 08, 2024 at 03:12:32PM -0400, Steven Sistare wrote: > > This is slightly tricky part and would be nice to be documented somewhere, > > perhaps starting from in the commit message. > > I will extend the block comment in qmp_migrate: > > /* > * For cpr-transfer, the target may

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-08 Thread Steven Sistare
On 10/8/2024 3:11 PM, Fabiano Rosas wrote: Peter Xu writes: On Tue, Oct 08, 2024 at 03:28:30PM -0300, Fabiano Rosas wrote: +/* Close cpr socket to tell source that we are listening */ +cpr_state_close(); Would it be possible to use some explicit reply message to mark this? In theo

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-08 Thread Steven Sistare
On 10/8/2024 2:47 PM, Peter Xu wrote: On Tue, Oct 08, 2024 at 03:28:30PM -0300, Fabiano Rosas wrote: +/* Close cpr socket to tell source that we are listening */ +cpr_state_close(); Would it be possible to use some explicit reply message to mark this? In theory yes, but I fear that u

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-08 Thread Steven Sistare
On 10/8/2024 11:45 AM, Peter Xu wrote: On Mon, Oct 07, 2024 at 04:39:25PM -0400, Steven Sistare wrote: On 10/7/2024 3:44 PM, Peter Xu wrote: On Mon, Sep 30, 2024 at 12:40:44PM -0700, Steve Sistare wrote: Add the cpr-transfer migration mode. Usage: qemu-system-$arch -machine anon-alloc=mem

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-08 Thread Fabiano Rosas
Peter Xu writes: > On Tue, Oct 08, 2024 at 03:28:30PM -0300, Fabiano Rosas wrote: >> >>> +/* Close cpr socket to tell source that we are listening */ >> >>> +cpr_state_close(); >> >> >> >> Would it be possible to use some explicit reply message to mark this? >> > >> > In theory yes, bu

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-08 Thread Peter Xu
On Tue, Oct 08, 2024 at 03:28:30PM -0300, Fabiano Rosas wrote: > >>> +/* Close cpr socket to tell source that we are listening */ > >>> +cpr_state_close(); > >> > >> Would it be possible to use some explicit reply message to mark this? > > > > In theory yes, but I fear that using a retur

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-08 Thread Fabiano Rosas
Steven Sistare writes: > On 10/7/2024 3:44 PM, Peter Xu wrote: >> On Mon, Sep 30, 2024 at 12:40:44PM -0700, Steve Sistare wrote: >>> Add the cpr-transfer migration mode. Usage: >>>qemu-system-$arch -machine anon-alloc=memfd ... >>> >>>start new QEMU with "-incoming -cpr-uri " >>> >>>

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-08 Thread Peter Xu
On Mon, Oct 07, 2024 at 04:39:25PM -0400, Steven Sistare wrote: > On 10/7/2024 3:44 PM, Peter Xu wrote: > > On Mon, Sep 30, 2024 at 12:40:44PM -0700, Steve Sistare wrote: > > > Add the cpr-transfer migration mode. Usage: > > >qemu-system-$arch -machine anon-alloc=memfd ... > > > > > >star

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-07 Thread Steven Sistare
On 10/7/2024 3:44 PM, Peter Xu wrote: On Mon, Sep 30, 2024 at 12:40:44PM -0700, Steve Sistare wrote: Add the cpr-transfer migration mode. Usage: qemu-system-$arch -machine anon-alloc=memfd ... start new QEMU with "-incoming -cpr-uri " Issue commands to old QEMU: migrate_set_param

Re: [PATCH V2 13/13] migration: cpr-transfer mode

2024-10-07 Thread Peter Xu
On Mon, Sep 30, 2024 at 12:40:44PM -0700, Steve Sistare wrote: > Add the cpr-transfer migration mode. Usage: > qemu-system-$arch -machine anon-alloc=memfd ... > > start new QEMU with "-incoming -cpr-uri " > > Issue commands to old QEMU: > migrate_set_parameter mode cpr-transfer > migr

[PATCH V2 13/13] migration: cpr-transfer mode

2024-09-30 Thread Steve Sistare
Add the cpr-transfer migration mode. Usage: qemu-system-$arch -machine anon-alloc=memfd ... start new QEMU with "-incoming -cpr-uri " Issue commands to old QEMU: migrate_set_parameter mode cpr-transfer migrate_set_parameter cpr-uri migrate -d The migrate command stops the VM, sav