Re: [PATCH V2 1/4] qapi: strList_from_string

2023-06-18 Thread Markus Armbruster
Steven Sistare writes: > On 6/13/2023 8:33 AM, Markus Armbruster wrote: >> Steven Sistare writes: [...] >>> What design principle does strList_from_string contradict? Are you OK with >>> putting the simplified version shown above in qapi-util? >> >> The design principle is "use JSON to enco

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-06-15 Thread Steven Sistare
On 6/13/2023 8:33 AM, Markus Armbruster wrote: > Steven Sistare writes: >> On 2/10/2023 4:25 AM, Markus Armbruster wrote: >>> Steven Sistare writes: On 2/9/2023 1:59 PM, Markus Armbruster wrote: > Steven Sistare writes: >> On 2/9/2023 11:46 AM, Markus Armbruster wrote: >>> Steve

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-06-13 Thread Markus Armbruster
Steven Sistare writes: > On 2/10/2023 4:25 AM, Markus Armbruster wrote: >> Steven Sistare writes: >> >>> On 2/9/2023 1:59 PM, Markus Armbruster wrote: Steven Sistare writes: > On 2/9/2023 11:46 AM, Markus Armbruster wrote: >> Steven Sistare writes: >> >> [...] >> >>> For mo

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-06-07 Thread Steven Sistare
On 2/10/2023 4:25 AM, Markus Armbruster wrote: > Steven Sistare writes: > >> On 2/9/2023 1:59 PM, Markus Armbruster wrote: >>> Steven Sistare writes: On 2/9/2023 11:46 AM, Markus Armbruster wrote: > Steven Sistare writes: > > [...] > >> For more context, this patch has been part

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-02-10 Thread Markus Armbruster
Steven Sistare writes: > On 2/9/2023 1:59 PM, Markus Armbruster wrote: >> Steven Sistare writes: >>> On 2/9/2023 11:46 AM, Markus Armbruster wrote: Steven Sistare writes: [...] > For more context, this patch has been part of my larger series for live > update, > and I am sub

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-02-09 Thread Steven Sistare
On 2/9/2023 1:59 PM, Markus Armbruster wrote: > Steven Sistare writes: >> On 2/9/2023 11:46 AM, Markus Armbruster wrote: >>> Steven Sistare writes: >>> On 2/9/2023 5:02 AM, Markus Armbruster wrote: > Alex Bennée writes: > >> Steven Sistare writes: >> >>> On 2/8/2023 1:4

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-02-09 Thread Markus Armbruster
Steven Sistare writes: > On 2/9/2023 11:46 AM, Markus Armbruster wrote: >> Steven Sistare writes: >> >>> On 2/9/2023 5:02 AM, Markus Armbruster wrote: Alex Bennée writes: > Steven Sistare writes: > >> On 2/8/2023 1:43 AM, Marc-André Lureau wrote: >>> Hi >>> >

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-02-09 Thread Steven Sistare
On 2/9/2023 11:46 AM, Markus Armbruster wrote: > Steven Sistare writes: > >> On 2/9/2023 5:02 AM, Markus Armbruster wrote: >>> Alex Bennée writes: >>> Steven Sistare writes: > On 2/8/2023 1:43 AM, Marc-André Lureau wrote: >> Hi >> >> On Tue, Feb 7, 2023 at 10:50 PM Ste

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-02-09 Thread Markus Armbruster
Steven Sistare writes: > On 2/9/2023 5:02 AM, Markus Armbruster wrote: >> Alex Bennée writes: >> >>> Steven Sistare writes: >>> On 2/8/2023 1:43 AM, Marc-André Lureau wrote: > Hi > > On Tue, Feb 7, 2023 at 10:50 PM Steve Sistare > wrote: >> >> Generalize hmp_spli

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-02-09 Thread Steven Sistare
On 2/9/2023 5:02 AM, Markus Armbruster wrote: > Alex Bennée writes: > >> Steven Sistare writes: >> >>> On 2/8/2023 1:43 AM, Marc-André Lureau wrote: Hi On Tue, Feb 7, 2023 at 10:50 PM Steve Sistare wrote: > > Generalize hmp_split_at_comma() to take any delimiter cha

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-02-09 Thread Markus Armbruster
Alex Bennée writes: > Steven Sistare writes: > >> On 2/8/2023 1:43 AM, Marc-André Lureau wrote: >>> Hi >>> >>> On Tue, Feb 7, 2023 at 10:50 PM Steve Sistare >>> wrote: Generalize hmp_split_at_comma() to take any delimiter character, rename as strList_from_string(), and move it

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-02-08 Thread Steven Sistare
On 2/8/2023 9:17 AM, Alex Bennée wrote: > Steven Sistare writes: > >> On 2/8/2023 1:43 AM, Marc-André Lureau wrote: >>> Hi >>> >>> On Tue, Feb 7, 2023 at 10:50 PM Steve Sistare >>> wrote: Generalize hmp_split_at_comma() to take any delimiter character, rename as strList_from_stri

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-02-08 Thread Alex Bennée
Steven Sistare writes: > On 2/8/2023 1:43 AM, Marc-André Lureau wrote: >> Hi >> >> On Tue, Feb 7, 2023 at 10:50 PM Steve Sistare >> wrote: >>> >>> Generalize hmp_split_at_comma() to take any delimiter character, rename >>> as strList_from_string(), and move it to qapi/util.c. >>> >>> No func

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-02-08 Thread Steven Sistare
On 2/8/2023 1:43 AM, Marc-André Lureau wrote: > Hi > > On Tue, Feb 7, 2023 at 10:50 PM Steve Sistare > wrote: >> >> Generalize hmp_split_at_comma() to take any delimiter character, rename >> as strList_from_string(), and move it to qapi/util.c. >> >> No functional change. > > The g_strsplit() v

Re: [PATCH V2 1/4] qapi: strList_from_string

2023-02-07 Thread Marc-André Lureau
Hi On Tue, Feb 7, 2023 at 10:50 PM Steve Sistare wrote: > > Generalize hmp_split_at_comma() to take any delimiter character, rename > as strList_from_string(), and move it to qapi/util.c. > > No functional change. The g_strsplit() version was a bit simpler, but if you want to optimize it a bit f

[PATCH V2 1/4] qapi: strList_from_string

2023-02-07 Thread Steve Sistare
Generalize hmp_split_at_comma() to take any delimiter character, rename as strList_from_string(), and move it to qapi/util.c. No functional change. Signed-off-by: Steve Sistare --- include/monitor/hmp.h | 1 - include/qapi/util.h| 9 + monitor/hmp-cmds.c | 19