Re: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-04-22 Thread Michael S. Tsirkin
On Tue, Mar 29, 2022 at 12:52:08PM +0800, Jason Wang wrote: > > 在 2022/3/28 下午4:53, Yi Liu 写道: > > > > > > On 2022/3/28 10:27, Jason Wang wrote: > > > On Thu, Mar 24, 2022 at 4:21 PM Tian, Kevin > > > wrote: > > > > > > > > > From: Jason Wang > > > > > Sent: Monday, March 21, 2022 1:54 PM > >

Re: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-04-21 Thread Jason Wang
On Fri, Apr 22, 2022 at 8:13 AM Peter Xu wrote: > > On Wed, Mar 30, 2022 at 04:36:36PM +0800, Jason Wang wrote: > > > If not, do we want to apply this version scheme only when it > > > reaches the production quality or also in the experimental phase? > > > > Yes. E.g if we think scalable mode is m

Re: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-04-21 Thread Peter Xu
On Wed, Mar 30, 2022 at 04:36:36PM +0800, Jason Wang wrote: > > If not, do we want to apply this version scheme only when it > > reaches the production quality or also in the experimental phase? > > Yes. E.g if we think scalable mode is mature, we can enable 3.0. Sorry to come back to the discuss

RE: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-04-05 Thread Tian, Kevin
> From: Jason Wang > Sent: Wednesday, April 6, 2022 11:33 AM > To: Tian, Kevin > Cc: Liu, Yi L ; m...@redhat.com; pet...@redhat.com; > yi.y@linux.intel.com; qemu-devel@nongnu.org > Subject: Re: [PATCH V2 1/4] intel-iommu: don't warn guest errors when > getting r

Re: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-04-05 Thread Jason Wang
On Sat, Apr 2, 2022 at 3:34 PM Tian, Kevin wrote: > > > From: Jason Wang > > Sent: Wednesday, March 30, 2022 4:37 PM > > On Wed, Mar 30, 2022 at 4:16 PM Tian, Kevin wrote: > > > > > > > From: Jason Wang > > > > Sent: Tuesday, March 29, 2022 12:52 PM > > > > > > > > > >>> > > > > >>> Currently t

RE: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-04-02 Thread Tian, Kevin
> From: Jason Wang > Sent: Wednesday, March 30, 2022 4:37 PM > On Wed, Mar 30, 2022 at 4:16 PM Tian, Kevin wrote: > > > > > From: Jason Wang > > > Sent: Tuesday, March 29, 2022 12:52 PM > > > > > > > >>> > > > >>> Currently the implementation of vtd_ce_get_rid2pasid_entry() is also > > > >>> pro

RE: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-03-30 Thread Tian, Kevin
> From: Jason Wang > Sent: Tuesday, March 29, 2022 12:52 PM > > > >>> > >>> Currently the implementation of vtd_ce_get_rid2pasid_entry() is also > >>> problematic. According to VT-d spec, RID2PASID field is effective only > >>> when ecap.rps is true otherwise PASID#0 is used for RID2PASID. I didn'

Re: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-03-30 Thread Jason Wang
On Wed, Mar 30, 2022 at 4:16 PM Tian, Kevin wrote: > > > From: Jason Wang > > Sent: Tuesday, March 29, 2022 12:52 PM > > > > > >>> > > >>> Currently the implementation of vtd_ce_get_rid2pasid_entry() is also > > >>> problematic. According to VT-d spec, RID2PASID field is effective only > > >>> wh

Re: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-03-28 Thread Jason Wang
在 2022/3/28 下午4:53, Yi Liu 写道: On 2022/3/28 10:27, Jason Wang wrote: On Thu, Mar 24, 2022 at 4:21 PM Tian, Kevin wrote: From: Jason Wang Sent: Monday, March 21, 2022 1:54 PM We use to warn on wrong rid2pasid entry. But this error could be triggered by the guest and could happens during

Re: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-03-28 Thread Yi Liu
On 2022/3/28 10:27, Jason Wang wrote: On Thu, Mar 24, 2022 at 4:21 PM Tian, Kevin wrote: From: Jason Wang Sent: Monday, March 21, 2022 1:54 PM We use to warn on wrong rid2pasid entry. But this error could be triggered by the guest and could happens during initialization. So let's don't wa

Re: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-03-27 Thread Jason Wang
On Thu, Mar 24, 2022 at 4:21 PM Tian, Kevin wrote: > > > From: Jason Wang > > Sent: Monday, March 21, 2022 1:54 PM > > > > We use to warn on wrong rid2pasid entry. But this error could be > > triggered by the guest and could happens during initialization. So > > let's don't warn in this case. > >

RE: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-03-24 Thread Tian, Kevin
> From: Jason Wang > Sent: Monday, March 21, 2022 1:54 PM > > We use to warn on wrong rid2pasid entry. But this error could be > triggered by the guest and could happens during initialization. So > let's don't warn in this case. > > Signed-off-by: Jason Wang > --- > hw/i386/intel_iommu.c | 6 ++

[PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-03-20 Thread Jason Wang
We use to warn on wrong rid2pasid entry. But this error could be triggered by the guest and could happens during initialization. So let's don't warn in this case. Signed-off-by: Jason Wang --- hw/i386/intel_iommu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/i386