Re: [PATCH V2 1/2] plugins: Fix resource leak in connect_socket()

On 11/9/20 2:20 AM, AlexChen wrote: > On 2020/11/6 21:17, Eric Blake wrote: >> On 11/5/20 7:59 PM, AlexChen wrote: >>> Close the fd when the connect() fails. >>> >>> Reported-by: Euler Robot >>> Signed-off-by: Alex Chen >> >> Your From: line ("AlexChen") is spelled differently than your S-o-b: >>

Re: [PATCH V2 1/2] plugins: Fix resource leak in connect_socket()

On 2020/11/6 21:17, Eric Blake wrote: > On 11/5/20 7:59 PM, AlexChen wrote: >> Close the fd when the connect() fails. >> >> Reported-by: Euler Robot >> Signed-off-by: Alex Chen > > Your From: line ("AlexChen") is spelled differently than your S-o-b: > line ("Alex Chen"). While this is not fatal

Re: [PATCH V2 1/2] plugins: Fix resource leak in connect_socket()

On 11/5/20 7:59 PM, AlexChen wrote: > Close the fd when the connect() fails. > > Reported-by: Euler Robot > Signed-off-by: Alex Chen Your From: line ("AlexChen") is spelled differently than your S-o-b: line ("Alex Chen"). While this is not fatal to the patch, it is confusing, so you may want t

[PATCH V2 1/2] plugins: Fix resource leak in connect_socket()

Close the fd when the connect() fails. Reported-by: Euler Robot Signed-off-by: Alex Chen --- contrib/plugins/lockstep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index a696673dff..319bd44b83 100644 --- a/contrib/plugins/lockstep.