Re: [PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-12 Thread Zhu, Lingshan
On 7/12/2023 3:22 PM, Jason Wang wrote: On Wed, Jul 12, 2023 at 2:54 PM Zhu, Lingshan wrote: On 7/11/2023 3:34 PM, Jason Wang wrote: On Tue, Jul 11, 2023 at 3:25 PM Eugenio Perez Martin wrote: On Tue, Jul 11, 2023 at 9:05 AM Jason Wang wrote: >

Re: [PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-12 Thread Jason Wang
On Wed, Jul 12, 2023 at 2:54 PM Zhu, Lingshan wrote: > > > On 7/11/2023 3:34 PM, Jason Wang wrote: > > > > On Tue, Jul 11, 2023 at 3:25 PM Eugenio Perez Martin > wrote: > >> On Tue, Jul 11, 2023 at 9:05 AM Jason Wang wrote: >> > >> > On Tue, Jul 11, 2023 at 12:09 PM Zhu, Lingshan >> wrote: >>

Re: [PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-11 Thread Zhu, Lingshan
On 7/11/2023 3:34 PM, Jason Wang wrote: On Tue, Jul 11, 2023 at 3:25 PM Eugenio Perez Martin wrote: On Tue, Jul 11, 2023 at 9:05 AM Jason Wang wrote: > > On Tue, Jul 11, 2023 at 12:09 PM Zhu, Lingshan wrote: > > > > > > > > On 7/11/2023 10:50 AM, Jaso

Re: [PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-11 Thread Jason Wang
On Tue, Jul 11, 2023 at 3:25 PM Eugenio Perez Martin wrote: > On Tue, Jul 11, 2023 at 9:05 AM Jason Wang wrote: > > > > On Tue, Jul 11, 2023 at 12:09 PM Zhu, Lingshan > wrote: > > > > > > > > > > > > On 7/11/2023 10:50 AM, Jason Wang wrote: > > > > On Mon, Jul 10, 2023 at 4:53 PM Zhu Lingshan

Re: [PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-11 Thread Eugenio Perez Martin
On Tue, Jul 11, 2023 at 9:05 AM Jason Wang wrote: > > On Tue, Jul 11, 2023 at 12:09 PM Zhu, Lingshan wrote: > > > > > > > > On 7/11/2023 10:50 AM, Jason Wang wrote: > > > On Mon, Jul 10, 2023 at 4:53 PM Zhu Lingshan > > > wrote: > > >> In the poweroff routine, no need to fetch last available in

Re: [PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-11 Thread Jason Wang
On Tue, Jul 11, 2023 at 12:09 PM Zhu, Lingshan wrote: > > > > On 7/11/2023 10:50 AM, Jason Wang wrote: > > On Mon, Jul 10, 2023 at 4:53 PM Zhu Lingshan wrote: > >> In the poweroff routine, no need to fetch last available index. > >> > > This is because there's no concept of shutdown in the vhost

Re: [PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-10 Thread Zhu, Lingshan
On 7/11/2023 10:50 AM, Jason Wang wrote: On Mon, Jul 10, 2023 at 4:53 PM Zhu Lingshan wrote: In the poweroff routine, no need to fetch last available index. This is because there's no concept of shutdown in the vhost layer, it only knows start and stop. This commit also provides a better

Re: [PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-10 Thread Jason Wang
On Mon, Jul 10, 2023 at 4:53 PM Zhu Lingshan wrote: > > In the poweroff routine, no need to fetch last available index. > This is because there's no concept of shutdown in the vhost layer, it only knows start and stop. > This commit also provides a better debug message in the vhost > caller vhos

Re: [PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-10 Thread Eugenio Perez Martin
On Mon, Jul 10, 2023 at 10:54 AM Zhu Lingshan wrote: > > In the poweroff routine, no need to fetch last available index. > > This commit also provides a better debug message in the vhost > caller vhost_virtqueue_stop, because if vhost does not fetch > the last avail idx successfully, maybe the dev

[PATCH V2] vhost_vdpa: no need to fetch vring base when poweroff

2023-07-10 Thread Zhu Lingshan
In the poweroff routine, no need to fetch last available index. This commit also provides a better debug message in the vhost caller vhost_virtqueue_stop, because if vhost does not fetch the last avail idx successfully, maybe the device does not suspend, vhost will sync last avail idx to vring use