Re: [PATCH V2] Handle wrap around in limit calculation

2024-01-18 Thread Shlomo Pongratz
--- *From:* Peter Maydell [mailto:peter.mayd...@linaro.org] *Sent:* Monday, January 15, 2024, 6:47 PM *To:* Shlomo Pongratz *Cc:* qemu-devel@nongnu.org, andrew.smi...@gmail.com, peter.mayd...@linaro.com, shlo...@pliops.com *Subject:* [PATCH V2] Handle wrap around in limit calcula

Re: [PATCH V2] Handle wrap around in limit calculation

2024-01-15 Thread Peter Maydell
On Mon, 15 Jan 2024 at 13:51, Shlomo Pongratz wrote: > > On 15/01/2024 12:37, Peter Maydell wrote: > > For instance, the kernel code suggests that pre-460A > > there's a 32 bit limit register, and post-460A there > > is a 64-bit limit (with an "UPPER_LIMIT" register to > > access the top 32 bits),

Re: [PATCH V2] Handle wrap around in limit calculation

2024-01-15 Thread Shlomo Pongratz
e a counter example.? thanks -- PMM *From:* Peter Maydell [mailto:peter.mayd...@linaro.org] *Sent:* Monday, January 15, 2024, 12:37 PM *To:* Shlomo Pongratz *Cc:* qemu-devel@nongnu.org, andrew.smi...@gmail.com, peter.mayd...@lina

Re: [PATCH V2] Handle wrap around in limit calculation

2024-01-15 Thread Peter Maydell
On Mon, 15 Jan 2024 at 05:58, Shlomo Pongratz wrote: > > Thank you. > Please see comments inline. > > On Fri, Jan 12, 2024 at 7:03 PM Peter Maydell > wrote: > > > > On Tue, 9 Jan 2024 at 12:45, Shlomo Pongratz > > wrote: > > > > Hi; thanks for this patch. > > > > > Hanlde wrap around caused by

Re: [PATCH V2] Handle wrap around in limit calculation

2024-01-14 Thread Shlomo Pongratz
Thank you. Please see comments inline. On Fri, Jan 12, 2024 at 7:03 PM Peter Maydell wrote: On Tue, 9 Jan 2024 at 12:45, Shlomo Pongratz wrote: Hi; thanks for this patch. Hanlde wrap around caused by the fact that perior to version 460A Is this "460A" version number a version of the hardw

Re: [PATCH V2] Handle wrap around in limit calculation

2024-01-14 Thread Shlomo Pongratz
Thank you. Please see comments inline. On Fri, Jan 12, 2024 at 7:03 PM Peter Maydell wrote: > > On Tue, 9 Jan 2024 at 12:45, Shlomo Pongratz wrote: > > Hi; thanks for this patch. > > > Hanlde wrap around caused by the fact that perior to version 460A > > Is this "460A" version number a version o

Re: [PATCH V2] Handle wrap around in limit calculation

2024-01-12 Thread Peter Maydell
On Tue, 9 Jan 2024 at 12:45, Shlomo Pongratz wrote: Hi; thanks for this patch. > Hanlde wrap around caused by the fact that perior to version 460A Is this "460A" version number a version of the hardware we're modelling ? > the limit was 32bit quantity. > See Linux kernel code in: > drivers/pci

[PATCH V2] Handle wrap around in limit calculation

2024-01-09 Thread Shlomo Pongratz
Hanlde wrap around caused by the fact that perior to version 460A the limit was 32bit quantity. See Linux kernel code in: drivers/pci/controllers/dwc/pcie-designware.c function: __dw_pcie_prog_outbound_atu Now in a 64bit system the range can be above 4G but as long as the limit itself is less then