Re: [PATCH V1] migration: cpr breaks SNP guest

2025-03-27 Thread Steven Sistare
On 3/27/2025 10:21 AM, Fabiano Rosas wrote: Steve Sistare writes: With aux-ram-share=off, booting an SNP guest fails with: ../util/error.c:68: error_setv: Assertion `*errp == NULL' failed. This is because a CPR blocker for the guest_memfd ramblock is added twice, once in ram_block_add_cpr

Re: [PATCH V1] migration: cpr breaks SNP guest

2025-03-27 Thread Fabiano Rosas
Steve Sistare writes: > With aux-ram-share=off, booting an SNP guest fails with: > > ../util/error.c:68: error_setv: Assertion `*errp == NULL' failed. > > This is because a CPR blocker for the guest_memfd ramblock is added > twice, once in ram_block_add_cpr_blocker because aux-ram-share=off so

Re: [PATCH V1] migration: cpr breaks SNP guest

2025-03-27 Thread Tom Lendacky
On 3/27/25 08:36, Steve Sistare wrote: > With aux-ram-share=off, booting an SNP guest fails with: > > ../util/error.c:68: error_setv: Assertion `*errp == NULL' failed. > > This is because a CPR blocker for the guest_memfd ramblock is added > twice, once in ram_block_add_cpr_blocker because aux-

[PATCH V1] migration: cpr breaks SNP guest

2025-03-27 Thread Steve Sistare
With aux-ram-share=off, booting an SNP guest fails with: ../util/error.c:68: error_setv: Assertion `*errp == NULL' failed. This is because a CPR blocker for the guest_memfd ramblock is added twice, once in ram_block_add_cpr_blocker because aux-ram-share=off so rb->fd < 0, and once in ram_block_