Re: [PATCH RFC v2 04/13] virtio: serialize extended features state

2025-07-16 Thread Akihiko Odaki
On 2025/07/16 0:40, Paolo Abeni wrote: On 7/15/25 9:24 AM, Akihiko Odaki wrote: On 2025/07/11 22:02, Paolo Abeni wrote: + */ +QEMU_BUILD_BUG_ON(VIRTIO_FEATURES_DWORDS != 2); +if (virtio_128bit_features_needed(vdev)) { There is no need to distinguish virtio_128bit_features_needed()

Re: [PATCH RFC v2 04/13] virtio: serialize extended features state

2025-07-15 Thread Paolo Abeni
On 7/15/25 9:24 AM, Akihiko Odaki wrote: > On 2025/07/11 22:02, Paolo Abeni wrote: >> + */ >> +QEMU_BUILD_BUG_ON(VIRTIO_FEATURES_DWORDS != 2); >> +if (virtio_128bit_features_needed(vdev)) { > > There is no need to distinguish virtio_128bit_features_needed() and > virtio_64bit_features

Re: [PATCH RFC v2 04/13] virtio: serialize extended features state

2025-07-15 Thread Akihiko Odaki
On 2025/07/11 22:02, Paolo Abeni wrote: If the driver uses any of the extended features (i.e. above 64), serialize the full features range (128 bits). This is one of the few spots that need explicitly to know and set in stone the extended features array size; add a build bug to prevent breaking

[PATCH RFC v2 04/13] virtio: serialize extended features state

2025-07-11 Thread Paolo Abeni
If the driver uses any of the extended features (i.e. above 64), serialize the full features range (128 bits). This is one of the few spots that need explicitly to know and set in stone the extended features array size; add a build bug to prevent breaking the migration should such size change agai