Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

On 2/22/22 14:06, Peter Maydell wrote: On Tue, 22 Feb 2022 at 12:56, Philippe Mathieu-Daudé wrote: On 22/2/22 13:02, Markus Armbruster wrote: Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and the RTC supports the event). What if there's more than one RTC? w.r.t. RTC, a

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

Markus Armbruster writes: > Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and > the RTC supports the event). What if there's more than one RTC? > Which one changed? New @qom-path identifies it. > > Signed-off-by: Markus Armbruster > --- > RFC because it's compile-tested on

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

On 22/2/22 14:06, Peter Maydell wrote: On Tue, 22 Feb 2022 at 12:56, Philippe Mathieu-Daudé wrote: On 22/2/22 13:02, Markus Armbruster wrote: Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and the RTC supports the event). What if there's more than one RTC? w.r.t. RTC, a

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

Philippe Mathieu-Daudé writes: > Hi Markus, > > On 22/2/22 13:02, Markus Armbruster wrote: >> Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and >> the RTC supports the event). What if there's more than one RTC? > > w.r.t. RTC, a machine having multiple RTC devices is silly..

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

On 22/2/22 16:04, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Hi Markus, On 22/2/22 13:02, Markus Armbruster wrote: Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and the RTC supports the event). What if there's more than one RTC? w.r.t. RTC, a machine havi

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

On Tue, 22 Feb 2022 at 12:56, Philippe Mathieu-Daudé wrote: > On 22/2/22 13:02, Markus Armbruster wrote: > > Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and > > the RTC supports the event). What if there's more than one RTC? > > w.r.t. RTC, a machine having multiple RTC dev

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

Hi Markus, On 22/2/22 13:02, Markus Armbruster wrote: Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and the RTC supports the event). What if there's more than one RTC? w.r.t. RTC, a machine having multiple RTC devices is silly... Assuming one wants to emulate that; shoul

[PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and the RTC supports the event). What if there's more than one RTC? Which one changed? New @qom-path identifies it. Signed-off-by: Markus Armbruster --- RFC because it's compile-tested only. Worthwhile? Let me know what you th