Re: [PATCH RFC 1/1] tcg: Always pass the full write size to notdirty_write()

2023-08-08 Thread Richard Henderson
On 8/8/23 02:59, Ilya Leoshkevich wrote: On Mon, 2023-08-07 at 11:21 -0700, Richard Henderson wrote: IIRC there are some uses of probe_access_* that set size == 0. Should we adjust addr+size to cover the whole page for that case? That seems to be the intent, anyway. There is a comment that say

Re: [PATCH RFC 1/1] tcg: Always pass the full write size to notdirty_write()

2023-08-08 Thread Ilya Leoshkevich
On Mon, 2023-08-07 at 11:21 -0700, Richard Henderson wrote: > On 8/7/23 06:56, Ilya Leoshkevich wrote: > > One of notdirty_write()'s responsibilities is detecting self- > > modifying > > code. Some functions pass the full size of a write to it, some pass > > 1. > > When a write to a code section be

Re: [PATCH RFC 1/1] tcg: Always pass the full write size to notdirty_write()

2023-08-07 Thread Richard Henderson
On 8/7/23 06:56, Ilya Leoshkevich wrote: One of notdirty_write()'s responsibilities is detecting self-modifying code. Some functions pass the full size of a write to it, some pass 1. When a write to a code section begins before a TB start, but then overlaps the TB, the paths that pass 1 don't flu

[PATCH RFC 1/1] tcg: Always pass the full write size to notdirty_write()

2023-08-07 Thread Ilya Leoshkevich
One of notdirty_write()'s responsibilities is detecting self-modifying code. Some functions pass the full size of a write to it, some pass 1. When a write to a code section begins before a TB start, but then overlaps the TB, the paths that pass 1 don't flush a TB and don't return to the translator