Re: [PATCH RFC] qga: fence guest-set-time if hwclock not available

2019-11-28 Thread Daniel P . Berrangé
On Thu, Nov 28, 2019 at 01:49:32PM +0100, Cornelia Huck wrote: > On Thu, 28 Nov 2019 12:45:32 + > Daniel P. Berrangé wrote: > > > On Thu, Nov 28, 2019 at 01:36:58PM +0100, Cornelia Huck wrote: > > > The Posix implementation of guest-set-time invokes hwclock to > > > set/retrieve the time to/f

Re: [PATCH RFC] qga: fence guest-set-time if hwclock not available

2019-11-28 Thread Laszlo Ersek
On 11/28/19 13:45, Daniel P. Berrangé wrote: > On Thu, Nov 28, 2019 at 01:36:58PM +0100, Cornelia Huck wrote: >> The Posix implementation of guest-set-time invokes hwclock to >> set/retrieve the time to/from the hardware clock. If hwclock >> is not available, the user is currently informed that "hw

Re: [PATCH RFC] qga: fence guest-set-time if hwclock not available

2019-11-28 Thread Cornelia Huck
On Thu, 28 Nov 2019 12:45:32 + Daniel P. Berrangé wrote: > On Thu, Nov 28, 2019 at 01:36:58PM +0100, Cornelia Huck wrote: > > The Posix implementation of guest-set-time invokes hwclock to > > set/retrieve the time to/from the hardware clock. If hwclock > > is not available, the user is curren

Re: [PATCH RFC] qga: fence guest-set-time if hwclock not available

2019-11-28 Thread Daniel P . Berrangé
On Thu, Nov 28, 2019 at 01:36:58PM +0100, Cornelia Huck wrote: > The Posix implementation of guest-set-time invokes hwclock to > set/retrieve the time to/from the hardware clock. If hwclock > is not available, the user is currently informed that "hwclock > failed to set hardware clock to system tim

[PATCH RFC] qga: fence guest-set-time if hwclock not available

2019-11-28 Thread Cornelia Huck
The Posix implementation of guest-set-time invokes hwclock to set/retrieve the time to/from the hardware clock. If hwclock is not available, the user is currently informed that "hwclock failed to set hardware clock to system time", which is quite misleading. This may happen e.g. on s390x, which has