Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-05-13 Thread John Snow
On 4/16/20 3:16 PM, Peter Maydell wrote: > On Thu, 16 Apr 2020 at 19:22, John Snow wrote: >> My goal is to make virtual environments work out of the box. >> >> I.e., if you run ./configure from inside a VENV, it should "just work." > > Yeah, this seems reasonable to me. If I understand your >

Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-16 Thread Peter Maydell
On Thu, 16 Apr 2020 at 19:22, John Snow wrote: > My goal is to make virtual environments work out of the box. > > I.e., if you run ./configure from inside a VENV, it should "just work." Yeah, this seems reasonable to me. If I understand your patch correctly it ought to work without breaking the s

Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-16 Thread John Snow
On 4/16/20 8:31 AM, Alex Bennée wrote: > > John Snow writes: > >> On 4/15/20 1:55 PM, Peter Maydell wrote: >>> On Wed, 15 Apr 2020 at 18:33, John Snow wrote: sphinx-build is the name of the script entry point from the sphinx package itself. sphinx-build-3 is a pacakging conven

Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-16 Thread Alex Bennée
John Snow writes: > On 4/15/20 1:55 PM, Peter Maydell wrote: >> On Wed, 15 Apr 2020 at 18:33, John Snow wrote: >>> >>> sphinx-build is the name of the script entry point from the sphinx >>> package itself. sphinx-build-3 is a pacakging convention by Linux >>> distributions. Prefer, where possi

Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-15 Thread Markus Armbruster
John Snow writes: > On 4/15/20 1:55 PM, Peter Maydell wrote: >> On Wed, 15 Apr 2020 at 18:33, John Snow wrote: >>> >>> sphinx-build is the name of the script entry point from the sphinx >>> package itself. sphinx-build-3 is a pacakging convention by Linux >>> distributions. Prefer, where possibl

Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-15 Thread John Snow
On 4/15/20 1:55 PM, Peter Maydell wrote: > On Wed, 15 Apr 2020 at 18:33, John Snow wrote: >> >> sphinx-build is the name of the script entry point from the sphinx >> package itself. sphinx-build-3 is a pacakging convention by Linux >> distributions. Prefer, where possible, the canonical package

Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-15 Thread Peter Maydell
On Wed, 15 Apr 2020 at 18:33, John Snow wrote: > > sphinx-build is the name of the script entry point from the sphinx > package itself. sphinx-build-3 is a pacakging convention by Linux > distributions. Prefer, where possible, the canonical package name. This was Markus's code originally; cc'ing

[PATCH RFC] configure: prefer sphinx-build to sphinx-build-3

2020-04-15 Thread John Snow
sphinx-build is the name of the script entry point from the sphinx package itself. sphinx-build-3 is a pacakging convention by Linux distributions. Prefer, where possible, the canonical package name. In the event that this resolves to a python2 version, test the suitability of the binary early in