Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-09-06 Thread Paolo Bonzini
On Mon, Sep 2, 2024 at 7:59 AM Junjie Mao wrote: > + '-print-file-name=libclang-' + host_clang_major + '.so', Note that libclang-MAJOR.so is a Debian-ism. On Fedora for example I have libclang.so.MAJOR.MINOR instead. Overall, this is a pain and I'd rather leave it to Meson developers to fix

Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-09-05 Thread Manos Pitsidianakis
On Wed, 04 Sep 2024 14:01, Paolo Bonzini wrote: On Wed, Aug 28, 2024 at 6:12 AM Manos Pitsidianakis wrote: Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visible to the rest of QEMU. The only comment I have is that I wou

Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-09-04 Thread Junjie Mao
On 9/4/2024 7:01 PM, Paolo Bonzini wrote: On Wed, Aug 28, 2024 at 6:12 AM Manos Pitsidianakis wrote: Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visible to the rest of QEMU. The only comment I have is that I would drop

Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-09-04 Thread Paolo Bonzini
On Wed, Aug 28, 2024 at 6:12 AM Manos Pitsidianakis wrote: > > Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and > provides some declaration macros for symbols visible to the rest of > QEMU. The only comment I have is that I would drop the allocator support completely. It a

Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-09-01 Thread Junjie Mao
On 8/31/2024 4:25 PM, Manos Pitsidianakis wrote: On Fri, 30 Aug 2024 14:03, Alex Bennée wrote: [.snip.] It is there:  /usr/lib/llvm-14/lib/clang/14.0.6/include/stdatomic.h in the search path:  clang -E -Wp,-v -  clang -cc1 version 14.0.6 based upon LLVM 14.0.6 default target x86_64-pc-linu

Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-08-31 Thread Manos Pitsidianakis
On Fri, 30 Aug 2024 14:03, Alex Bennée wrote: [.snip.] It is there: /usr/lib/llvm-14/lib/clang/14.0.6/include/stdatomic.h in the search path: clang -E -Wp,-v - clang -cc1 version 14.0.6 based upon LLVM 14.0.6 default target x86_64-pc-linux-gnu ignoring nonexistent directory "/usr/bin/.

Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-08-30 Thread Alex Bennée
Junjie Mao writes: > On 8/28/2024 9:08 PM, Alex Bennée wrote: >> Manos Pitsidianakis writes: >> >>> Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and >>> provides some declaration macros for symbols visible to the rest of >>> QEMU. >> As mentioned on IRC I'm hitting a com

Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-08-30 Thread Junjie Mao
On 8/30/2024 2:43 PM, Manos Pitsidianakis wrote: 🎱 On Fri, 30 Aug 2024, 04:19 Junjie Mao, > wrote: On 8/28/2024 9:08 PM, Alex Bennée wrote: > Manos Pitsidianakis mailto:manos.pitsidiana...@linaro.org>> writes: > >> Add rust/qemu-api, which expose

Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-08-29 Thread Manos Pitsidianakis
🎱 On Fri, 30 Aug 2024, 04:19 Junjie Mao, wrote: > On 8/28/2024 9:08 PM, Alex Bennée wrote: > > Manos Pitsidianakis writes: > > > >> Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and > >> provides some declaration macros for symbols visible to the rest of > >> QEMU. > > >

Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-08-29 Thread Junjie Mao
On 8/28/2024 9:08 PM, Alex Bennée wrote: Manos Pitsidianakis writes: Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visible to the rest of QEMU. As mentioned on IRC I'm hitting a compilation error that bisects to this com

Re: [PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-08-28 Thread Alex Bennée
Manos Pitsidianakis writes: > Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and > provides some declaration macros for symbols visible to the rest of > QEMU. As mentioned on IRC I'm hitting a compilation error that bisects to this commit: [148/1010] Generating bindings

[PATCH RESEND v9 7/9] rust: add crate to expose bindings and interfaces

2024-08-27 Thread Manos Pitsidianakis
Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visible to the rest of QEMU. Co-authored-by: Junjie Mao Co-authored-by: Paolo Bonzini Signed-off-by: Junjie Mao Signed-off-by: Paolo Bonzini Signed-off-by: Manos Pitsidianakis