Re: [PATCH RESEND 03/10] target/ppc: Move mffsl to decodetree

2022-05-17 Thread Richard Henderson
On 5/17/22 09:47, Víctor Colombo wrote: -do_mffsc(a->rt); +do_mffsc(a->rt, 0xULL); BTW, prefer -1 or ~0 or UINT64_MAX. No one needs to count F's. r~

Re: [PATCH RESEND 03/10] target/ppc: Move mffsl to decodetree

2022-05-17 Thread Richard Henderson
On 5/17/22 09:47, Víctor Colombo wrote: Signed-off-by: Víctor Colombo --- target/ppc/insn32.decode | 4 target/ppc/translate/fp-impl.c.inc | 27 --- target/ppc/translate/fp-ops.c.inc | 2 -- 3 files changed, 12 insertions(+), 21 deletions(-) Review

[PATCH RESEND 03/10] target/ppc: Move mffsl to decodetree

2022-05-17 Thread Víctor Colombo
Signed-off-by: Víctor Colombo --- target/ppc/insn32.decode | 4 target/ppc/translate/fp-impl.c.inc | 27 --- target/ppc/translate/fp-ops.c.inc | 2 -- 3 files changed, 12 insertions(+), 21 deletions(-) diff --git a/target/ppc/insn32.decode b/target/ppc/i