Re: [PATCH 9/9] target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ()

2020-12-05 Thread Richard Henderson
On 12/4/20 4:53 PM, Philippe Mathieu-Daudé wrote: > Yes, will follow. I'm tempted to inline gen_check_zero_element (actually > move gen_msa_BxZ as gen_check_zero_element prologue/epilogue). Not sure > gen_check_zero_element() can be reused later though. The other thing that could happen is that ge

Re: [PATCH 9/9] target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ()

2020-12-04 Thread Philippe Mathieu-Daudé
On 12/4/20 6:04 PM, Richard Henderson wrote: > On 12/2/20 12:44 PM, Philippe Mathieu-Daudé wrote: >> +static bool gen_msa_BxZ(DisasContext *ctx, int df, int wt, int s16, bool >> if_not) >> +{ >> +check_msa_access(ctx); >> + >> +if (ctx->hflags & MIPS_HFLAG_BMASK) { >> +generate_exc

Re: [PATCH 9/9] target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ()

2020-12-04 Thread Richard Henderson
On 12/2/20 12:44 PM, Philippe Mathieu-Daudé wrote: > +static bool gen_msa_BxZ(DisasContext *ctx, int df, int wt, int s16, bool > if_not) > +{ > +check_msa_access(ctx); > + > +if (ctx->hflags & MIPS_HFLAG_BMASK) { > +generate_exception_end(ctx, EXCP_RI); > +return true; > +

[PATCH 9/9] target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ()

2020-12-02 Thread Philippe Mathieu-Daudé
In preparation of using the decodetree script, explode gen_msa_branch() as following: - OPC_BZ_V -> BxZ_V(EQ) - OPC_BNZ_V -> BxZ_V(NE) - OPC_BZ_[BHWD] -> BxZ(false) - OPC_BNZ_[BHWD]-> BxZ(true) Signed-off-by: Philippe Mathieu-Daudé --- target/mips/transl