Re: [PATCH 8/9] vnc: add support for extended desktop resize

2020-12-04 Thread Daniel P . Berrangé
On Fri, Dec 04, 2020 at 07:37:50AM +0100, Gerd Hoffmann wrote: > Hi, > > > > +case VNC_ENCODING_DESKTOP_RESIZE_EXT: > > > +vs->features |= VNC_FEATURE_RESIZE_EXT_MASK; > > > > IIUC, we shouldn't set this flag unless all current displays adapters > > associated with the VNC s

Re: [PATCH 8/9] vnc: add support for extended desktop resize

2020-12-04 Thread Marc-André Lureau
Hi On Thu, Dec 3, 2020 at 3:13 PM Gerd Hoffmann wrote: > The extended desktop resize encoding adds support for (a) clients > sending resize requests to the server, and (b) multihead support. > > This patch implements (a). All resize requests are rejected by qemu. > Qemu can't resize the framebu

Re: [PATCH 8/9] vnc: add support for extended desktop resize

2020-12-04 Thread Daniel P . Berrangé
On Thu, Dec 03, 2020 at 12:08:04PM +0100, Gerd Hoffmann wrote: > The extended desktop resize encoding adds support for (a) clients > sending resize requests to the server, and (b) multihead support. > > This patch implements (a). All resize requests are rejected by qemu. > Qemu can't resize the f

Re: [PATCH 8/9] vnc: add support for extended desktop resize

2020-12-03 Thread Gerd Hoffmann
Hi, > > +case VNC_ENCODING_DESKTOP_RESIZE_EXT: > > +vs->features |= VNC_FEATURE_RESIZE_EXT_MASK; > > IIUC, we shouldn't set this flag unless all current displays adapters > associated with the VNC server support the "ui_info" callbacks, > otherwise the client will think it c

Re: [PATCH 8/9] vnc: add support for extended desktop resize

2020-12-03 Thread Daniel P . Berrangé
On Thu, Dec 03, 2020 at 12:08:04PM +0100, Gerd Hoffmann wrote: > The extended desktop resize encoding adds support for (a) clients > sending resize requests to the server, and (b) multihead support. > > This patch implements (a). All resize requests are rejected by qemu. > Qemu can't resize the f

[PATCH 8/9] vnc: add support for extended desktop resize

2020-12-03 Thread Gerd Hoffmann
The extended desktop resize encoding adds support for (a) clients sending resize requests to the server, and (b) multihead support. This patch implements (a). All resize requests are rejected by qemu. Qemu can't resize the framebuffer on its own, this is in the hands of the guest, so all qemu can