Re: [PATCH 7/8] chardev/mux: implement detach of frontends from mux

2024-10-14 Thread Roman Penyaev
On Mon, Oct 14, 2024 at 3:22 PM Marc-André Lureau wrote: [cut] >> >> +bool mux_chr_detach_frontend(MuxChardev *d, unsigned int tag) >> +{ >> +unsigned int bit; >> + >> +bit = find_next_bit(&d->mux_bitset, MAX_MUX, tag); >> +if (bit >= MAX_MUX) { > > > if (bit != tag) instead? Right,

Re: [PATCH 7/8] chardev/mux: implement detach of frontends from mux

2024-10-14 Thread Marc-André Lureau
Hi On Mon, Oct 14, 2024 at 3:46 PM Roman Penyaev wrote: > With bitset management now it becomes feasible to implement > the logic of detaching frontends from multiplexer. > > Signed-off-by: Roman Penyaev > Cc: "Marc-André Lureau" > Cc: qemu-devel@nongnu.org > --- > chardev/char-fe.c

[PATCH 7/8] chardev/mux: implement detach of frontends from mux

2024-10-14 Thread Roman Penyaev
With bitset management now it becomes feasible to implement the logic of detaching frontends from multiplexer. Signed-off-by: Roman Penyaev Cc: "Marc-André Lureau" Cc: qemu-devel@nongnu.org --- chardev/char-fe.c | 2 +- chardev/char-mux.c | 20 +--- chardev/cha