Re: [PATCH 7/7] spice: Call qemu spice functions indirectly

2020-08-04 Thread Gerd Hoffmann
> > #ifdef CONFIG_SPICE > > +SpiceInfo *qmp_query_spice(Error **errp) > > +{ > > +if (!using_spice) { > > +return NULL; > > +} > > +return qemu_spice.query(errp); > > +} > > + > > It's a bit weird to put the qmp function in the hmp file. Yes, it should go to qmp-cmds.c instea

Re: [PATCH 7/7] spice: Call qemu spice functions indirectly

2020-08-04 Thread Gerd Hoffmann
Hi, These stubs (picked two examples) ... > -static inline int qemu_spice_set_passwd(const char *passwd, > -bool fail_if_connected, > -bool disconnect_if_connected) > -{ > -return -1; > -} > -static inline void

Re: [PATCH 7/7] spice: Call qemu spice functions indirectly

2020-07-27 Thread Dr. David Alan Gilbert
* Christophe de Dinechin (dinec...@redhat.com) wrote: > In order to be able to move all of spice in a shared library that is > loaded dynamically only on demand, this commit puts the functions > called by the main binary in a QemuSpiceOps structure, and use static > inline stubs to preserve the cal

[PATCH 7/7] spice: Call qemu spice functions indirectly

2020-07-23 Thread Christophe de Dinechin
In order to be able to move all of spice in a shared library that is loaded dynamically only on demand, this commit puts the functions called by the main binary in a QemuSpiceOps structure, and use static inline stubs to preserve the call sites. With these changes, the following shared libraries a