Re: [PATCH 7/7] hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE

2020-08-17 Thread Kevin Wolf
Am 14.08.2020 um 10:28 hat Philippe Mathieu-Daudé geschrieben: > Use self-explicit definitions instead of magic '512' value. > > Signed-off-by: Philippe Mathieu-Daudé In this patch, BDRV_SECTOR_SIZE actually looks correct to me. The values have already been converted from s->qdev.blocksize in

Re: [PATCH 7/7] hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE

2020-08-15 Thread Li Qiang
Philippe Mathieu-Daudé 于2020年8月14日周五 下午4:34写道: > > Use self-explicit definitions instead of magic '512' value. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang > --- > hw/scsi/scsi-disk.c | 44 +++- > 1 file changed, 23 insertions(+), 21

Re: [PATCH 7/7] hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE

2020-08-14 Thread Richard Henderson
On 8/14/20 1:28 AM, Philippe Mathieu-Daudé wrote: > Use self-explicit definitions instead of magic '512' value. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/scsi/scsi-disk.c | 44 +++- > 1 file changed, 23 insertions(+), 21 deletions(-) Reviewed-b

[PATCH 7/7] hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE

2020-08-14 Thread Philippe Mathieu-Daudé
Use self-explicit definitions instead of magic '512' value. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/scsi-disk.c | 44 +++- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 8ce68a9dd6.