Re: [PATCH 65/67] ppc/kconfig: make SAM460EX depend on PPC & PIXMAN

2023-09-06 Thread Paolo Bonzini
On Tue, Sep 5, 2023 at 10:07 PM Marc-André Lureau wrote: > Indeed, and it is disabled not by Kconfig but by meson: > system_ss.add(when: [pixman, 'CONFIG_ATI_VGA'], if_true: > files('ati.c', 'ati_2d.c', 'ati_dbg.c')) It's better to add a "depends on", so that it fails to compile with --disable-pi

Re: [PATCH 65/67] ppc/kconfig: make SAM460EX depend on PPC & PIXMAN

2023-09-05 Thread Marc-André Lureau
Hi On Wed, Aug 30, 2023 at 4:35 PM BALATON Zoltan wrote: > > On Wed, 30 Aug 2023, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > SM501 is going to depend on PIXMAN next. > > Why is this patch needed when SM501 is the one that depends on PIXMAN and > should pull in the dep

Re: [PATCH 65/67] ppc/kconfig: make SAM460EX depend on PPC & PIXMAN

2023-09-04 Thread Paolo Bonzini
On 8/30/23 14:34, BALATON Zoltan wrote: From: Marc-André Lureau SM501 is going to depend on PIXMAN next. Why is this patch needed when SM501 is the one that depends on PIXMAN and should pull in the dependency? Also what's the change in default.mak? The change in default.mak is needed be

Re: [PATCH 65/67] ppc/kconfig: make SAM460EX depend on PPC & PIXMAN

2023-09-04 Thread Paolo Bonzini
On 8/30/23 11:38, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau SM501 is going to depend on PIXMAN next. Signed-off-by: Marc-André Lureau --- configs/devices/ppc-softmmu/default.mak | 2 +- hw/ppc/Kconfig | 2 ++ 2 files changed, 3 insertions(+), 1 dele

Re: [PATCH 65/67] ppc/kconfig: make SAM460EX depend on PPC & PIXMAN

2023-08-30 Thread BALATON Zoltan
On Wed, 30 Aug 2023, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau SM501 is going to depend on PIXMAN next. Why is this patch needed when SM501 is the one that depends on PIXMAN and should pull in the dependency? Also what's the change in default.mak? ati-vga also uses pixman a

[PATCH 65/67] ppc/kconfig: make SAM460EX depend on PPC & PIXMAN

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau SM501 is going to depend on PIXMAN next. Signed-off-by: Marc-André Lureau --- configs/devices/ppc-softmmu/default.mak | 2 +- hw/ppc/Kconfig | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/configs/devices/ppc-softmmu/defaul