Re: [PATCH 6/7] hw/isa: Assert isa_register_portio_list() gets non-NULL ISA device

2023-02-14 Thread Philippe Mathieu-Daudé
On 14/2/23 19:49, Richard Henderson wrote: On 2/14/23 00:18, Philippe Mathieu-Daudé wrote:   __attribute__((nonnull)) void a1(void *ptr)   {     // can no use assert(ptr) because compiler warning   } I briefly glossed over that... I realize we'd probably want to add -fno-delete-null-pointer-c

Re: [PATCH 6/7] hw/isa: Assert isa_register_portio_list() gets non-NULL ISA device

2023-02-14 Thread Richard Henderson
On 2/14/23 00:18, Philippe Mathieu-Daudé wrote:  __attribute__((nonnull)) void a1(void *ptr)  {    // can no use assert(ptr) because compiler warning  } I briefly glossed over that... I realize we'd probably want to add -fno-delete-null-pointer-checks if we make too much ... here. The

Re: [PATCH 6/7] hw/isa: Assert isa_register_portio_list() gets non-NULL ISA device

2023-02-14 Thread Philippe Mathieu-Daudé
On 8/2/23 20:47, Richard Henderson wrote: On 2/7/23 14:07, Philippe Mathieu-Daudé wrote: The previous commit removed the single call to isa_register_portio_list() with dev=NULL. To be sure we won't reintroduce such weird (ab)use, add an assertion. Signed-off-by: Philippe Mathieu-Daudé Review

Re: [PATCH 6/7] hw/isa: Assert isa_register_portio_list() gets non-NULL ISA device

2023-02-08 Thread Richard Henderson
On 2/7/23 14:07, Philippe Mathieu-Daudé wrote: The previous commit removed the single call to isa_register_portio_list() with dev=NULL. To be sure we won't reintroduce such weird (ab)use, add an assertion. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson I wonder how muc

[PATCH 6/7] hw/isa: Assert isa_register_portio_list() gets non-NULL ISA device

2023-02-07 Thread Philippe Mathieu-Daudé
The previous commit removed the single call to isa_register_portio_list() with dev=NULL. To be sure we won't reintroduce such weird (ab)use, add an assertion. Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/isa-bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/isa/