Re: [PATCH 5/9] util/vfio-helpers: Remove unreachable code in qemu_vfio_dma_map()

2021-08-25 Thread Klaus Jensen
On Aug 25 13:53, Klaus Jensen wrote: > On Aug 24 16:11, Philippe Mathieu-Daudé wrote: > > qemu_vfio_add_mapping() returns a pointer to an indexed entry > > in pre-allocated QEMUVFIOState::mappings[], thus can not be NULL. > > Remove the pointless check. > > > > Signed-off-by: Philippe Mathieu-Daud

Re: [PATCH 5/9] util/vfio-helpers: Remove unreachable code in qemu_vfio_dma_map()

2021-08-25 Thread Klaus Jensen
On Aug 24 16:11, Philippe Mathieu-Daudé wrote: > qemu_vfio_add_mapping() returns a pointer to an indexed entry > in pre-allocated QEMUVFIOState::mappings[], thus can not be NULL. > Remove the pointless check. > > Signed-off-by: Philippe Mathieu-Daudé > --- > util/vfio-helpers.c | 4 > 1 fil

[PATCH 5/9] util/vfio-helpers: Remove unreachable code in qemu_vfio_dma_map()

2021-08-24 Thread Philippe Mathieu-Daudé
qemu_vfio_add_mapping() returns a pointer to an indexed entry in pre-allocated QEMUVFIOState::mappings[], thus can not be NULL. Remove the pointless check. Signed-off-by: Philippe Mathieu-Daudé --- util/vfio-helpers.c | 4 1 file changed, 4 deletions(-) diff --git a/util/vfio-helpers.c b/u